This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Fix not_reserved negative lookahead regex. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for me |
ralphbean
added a commit
that referenced
this pull request
Mar 24, 2015
…f-jcapik Fix not_reserved negative lookahead regex.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we hit the embarrassing situation of a user named 'jcapik' being unable
to visit their profile. I figured out with some curl tests that it was because
'api' was a substring of 'jcapik'. @pypingou found this werkzeug converter
that we use which seems to be to blame.
In local tests, I was unable to visit a 'jcapik' profile page locally until I
made this change, but I can visit it now after the change. The api, static,
and confirm endpoints are also still accessible.