Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
Browse files Browse the repository at this point in the history
Revert "Add HandleScope to http-parser binding"
This commit did not actually fix the production crashes.

This reverts commit 73cf8e8.
  • Loading branch information
ry committed Dec 28, 2011
1 parent d483acc commit 448c5e0
Showing 1 changed file with 10 additions and 16 deletions.
26 changes: 10 additions & 16 deletions src/node_http_parser.cc
Expand Up @@ -119,17 +119,15 @@ static size_t current_buffer_len;


#define HTTP_CB(name) \
static int name(http_parser* p_) { \
HandleScope scope; \
Parser* self = container_of(p_, Parser, parser_); \
return self->name##_(); \
} \
int always_inline name##_()
static int name(http_parser* p_) { \
Parser* self = container_of(p_, Parser, parser_); \
return self->name##_(); \
} \
int always_inline name##_()


#define HTTP_DATA_CB(name) \
static int name(http_parser* p_, const char* at, size_t length) { \
HandleScope scope; \
Parser* self = container_of(p_, Parser, parser_); \
return self->name##_(at, length); \
} \
Expand Down Expand Up @@ -214,12 +212,10 @@ struct StringPtr {


Handle<String> ToString() const {
HandleScope scope;
if (str_) {
return scope.Close(String::New(str_, size_));
} else {
return scope.Close(String::Empty());
}
if (str_)
return String::New(str_, size_);
else
return String::Empty();
}


Expand Down Expand Up @@ -517,8 +513,6 @@ class Parser : public ObjectWrap {
private:

Local<Array> CreateHeaders() {
HandleScope scope;

// num_values_ is either -1 or the entry # of the last header
// so num_values_ == 0 means there's a single header
Local<Array> headers = Array::New(2 * (num_values_ + 1));
Expand All @@ -528,7 +522,7 @@ class Parser : public ObjectWrap {
headers->Set(2 * i + 1, values_[i].ToString());
}

return scope.Close(headers);
return headers;
}


Expand Down

0 comments on commit 448c5e0

Please sign in to comment.