Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 942de8d6b16d
Choose a base ref
...
head repository: cdk/cdk
compare: 1fe75a774950
Choose a head ref
  • 15 commits
  • 293 files changed
  • 1 contributor

Commits on Aug 8, 2014

  1. Parameterized generic types 

    Change-Id: I2bbc37af6e0f0c04a3d9f3e8a0adaaf66461b8d1
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    159944c View commit details
    Browse the repository at this point in the history

  2. Parameterized generic types 

    Change-Id: I0d7e19c187f5f45be94d09232ae678809e9cddf8
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    5e8275e View commit details
    Browse the repository at this point in the history

  3. Typed the Comparator 

    Change-Id: I010ca701c13010fc50d91d8a5584b44929321f3b
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    7ac5e2c View commit details
    Browse the repository at this point in the history

  4. Added more closing of IO resources 

    Change-Id: I68cd72f7a2c761c969cc707f0492b0f0f87c9591
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    c1c8e49 View commit details
    Browse the repository at this point in the history

  5. Removed redundant, floating JavaDoc 

    Change-Id: Ic77fc2855efcc34b9b4888e769e1e088b4982f8c
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    da2f30b View commit details
    Browse the repository at this point in the history

  6. Removed unused imports 

    Change-Id: If4342394f117be2b6d5d3567e4d22c8d046f83dc
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    ac9cabe View commit details
    Browse the repository at this point in the history

  7. Removed redundant, floating JavaDoc 

    Change-Id: I3b4b36d2ebba8db78c3b1c11a3da83ca730f222e
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    cdab730 View commit details
    Browse the repository at this point in the history

  8. Synchronized the APIs with the changes introduced in commit 5baedfe 

    Change-Id: I2e3b403b2d70f216314c64efaa99503095551120
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    e960aad View commit details
    Browse the repository at this point in the history

  9. Use Integer|Double.valueof() 

    Change-Id: Idba9d882c9fd1cf22b7a336e3d6920db09ae1647
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    c8261e8 View commit details
    Browse the repository at this point in the history

  10. Removed redundant check 

    Change-Id: Ib4bb3fd098d25dc1f9a1d916c62a325a6a5fda37
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    e549541 View commit details
    Browse the repository at this point in the history

  11. Simpler and/or more efficient String handling 

    Change-Id: Ib46973c7f67ea8345ac13d347bed0febeae43780
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    1558c34 View commit details
    Browse the repository at this point in the history

  12. Use equals() to compare String's 

    Change-Id: I7f9ec954265ef1771e6f4ce66788f5d464b25505
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    270a09f View commit details
    Browse the repository at this point in the history

  13. Use indexOf(char) instead of indexOf(String) whenever possible 

    Change-Id: I6aee376b35df4b61abbdde8551281e937110bb7e
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    4d84653 View commit details
    Browse the repository at this point in the history

  14. Various optimizations. 

    - the ILoggingTool allows you to pass an arbitrary number of parameters, which it will concatenate
  only when that logging level is turned on. In many cases it means less String concatenation.
- use charAt(chat) instead of startsWith(char)
- removed a needless String instantiation

Change-Id: I9da89d4d51c704c4615e03db5a63678926459f56
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    29c967d View commit details
    Browse the repository at this point in the history

  15. Also updated the silent MolecularFormula class 

    Change-Id: If5b5c2c5179ddc8dedb32a89da76cd2110bc768d
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Aug 8, 2014
    Copy the full SHA
    1fe75a7 View commit details
    Browse the repository at this point in the history