add button_to helper to Mojolicious::Plugin::TagHelpers

mojolicious · Apr 2, 2015 · ed26e91 · ed26e91
1 parent 05fa333
commit ed26e91
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 20 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
 6.06  2015-04-02
+  - Added button_to helper to Mojolicious::Plugin::TagHelpers.
   - Added "chat.pl" to example scripts.
 
 6.05  2015-03-24

diff --git a/lib/Mojolicious/Plugin/TagHelpers.pm b/lib/Mojolicious/Plugin/TagHelpers.pm
@@ -14,33 +14,29 @@ sub register {
     $app->helper("${name}_field" => sub { _input(@_, type => $name) });
   }
 
+  my @helpers = (
+    qw(button_to csrf_field form_for hidden_field javascript label_for),
+    qw(link_to password_field select_field stylesheet submit_button),
+    qw(tag_with_error text_area)
+  );
+  $app->helper($_ => __PACKAGE__->can("_$_")) for @helpers;
+
   $app->helper(check_box =>
       sub { _input(shift, shift, value => shift, @_, type => 'checkbox') });
-  $app->helper(csrf_field => \&_csrf_field);
   $app->helper(file_field =>
       sub { shift; _tag('input', name => shift, @_, type => 'file') });
-
-  $app->helper(form_for     => \&_form_for);
-  $app->helper(hidden_field => \&_hidden_field);
   $app->helper(image => sub { _tag('img', src => shift->url_for(shift), @_) });
   $app->helper(input_tag => sub { _input(@_) });
-  $app->helper(javascript => \&_javascript);
-  $app->helper(label_for  => \&_label_for);
-  $app->helper(link_to    => \&_link_to);
-
-  $app->helper(password_field => \&_password_field);
   $app->helper(radio_button =>
       sub { _input(shift, shift, value => shift, @_, type => 'radio') });
 
-  $app->helper(select_field  => \&_select_field);
-  $app->helper(stylesheet    => \&_stylesheet);
-  $app->helper(submit_button => \&_submit_button);
-
   # "t" is just a shortcut for the "tag" helper
   $app->helper($_ => sub { shift; _tag(@_) }) for qw(t tag);
+}
 
-  $app->helper(tag_with_error => \&_tag_with_error);
-  $app->helper(text_area      => \&_text_area);
+sub _button_to {
+  my ($c, $text) = (shift, shift);
+  return _form_for($c, @_, sub { _submit_button($c, $text) });
 }
 
 sub _csrf_field {
@@ -260,6 +256,28 @@ by default.
 
 L<Mojolicious::Plugin::TagHelpers> implements the following helpers.
 
+=head2 button_to
+
+  %= button_to 'Test' => 'some_get_route'
+  %= button_to 'Test' => some_get_route => {id => 23} => (class => 'menu')
+  %= button_to 'Test' => 'http://example.com/test' => (class => 'menu')
+  %= button_to 'Remove' => 'some_delete_route'
+
+Generate portable C<form> tag with L</"form_for"> containing a single button.
+
+  <form action="/path/to/get/route">
+    <input type="submit" value="Test">
+  </form>
+  <form action="/path/to/get/route/23" class="menu">
+    <input type="submit" value="Test">
+  </form>
+  <form action="http://example.com/test" class="menu">
+    <input type="submit" value="Test">
+  </form>
+  <form action="/path/to/delete/route?_method=DELETE" method="POST">
+    <input type="submit" value="Remove">
+  </form>
+
 =head2 check_box
 
   %= check_box employed => 1
@@ -371,22 +389,22 @@ C<_method> query parameter will be added as well.
 
   <form action="/path/to/login">
     <input name="first_name" type="text">
-    <input value="Ok" type="submit">
+    <input type="submit" value="Ok">
   </form>
   <form action="/path/to/login.txt" method="POST">
     <input name="first_name" type="text">
-    <input value="Ok" type="submit">
+    <input type="submit" value="Ok">
   </form>
   <form action="/path/to/login" enctype="multipart/form-data">
     <input disabled="disabled" name="first_name" type="text">
-    <input value="Ok" type="submit">
+    <input type="submit" value="Ok">
   </form>
   <form action="http://example.com/login" method="POST">
     <input name="first_name" type="text">
-    <input value="Ok" type="submit">
+    <input type="submit" value="Ok">
   </form>
   <form action="/path/to/delete/route?_method=DELETE" method="POST">
-    <input value="Remove" type="submit">
+    <input type="submit" value="Remove">
   </form>
 
 =head2 hidden_field

diff --git a/t/mojolicious/tag_helper_lite_app.t b/t/mojolicious/tag_helper_lite_app.t
@@ -16,6 +16,8 @@ get 'tags_with_error';
 
 any [qw(GET POST)] => 'links';
 
+get '/buttons';
+
 get 'script';
 
 get 'style';
@@ -105,6 +107,14 @@ $t->post_ok('/links')->status_is(200)->content_is(<<'EOF');
 <a href="/form/23" title="Foo">Foo</a>
 EOF
 
+# Buttons
+$t->get_ok('/buttons')->status_is(200)->content_is(<<'EOF');
+<form action="/links"><input type="submit" value="First test"></form>
+<form action="/links.txt"><input type="submit" value="Second"></form>
+<form action="/" class="menu"><input type="submit" value="Third"></form>
+<form action="http://example.com"><input type="submit" value="Fourth"></form>
+EOF
+
 # Scripts
 $t->get_ok('/script')->status_is(200)->content_is(<<EOF);
 <script src="/script.js"></script>
@@ -509,6 +519,12 @@ __DATA__
 <%= link_to Foo => 'form', {test => 23}, title => 'Foo' %>
 <%= link_to form => {test => 23} => (title => 'Foo') => begin %>Foo<% end %>
 
+@@ buttons.html.ep
+%= button_to 'First test' => 'links'
+%= button_to 'Second' => 'links' => {format => 'txt'}
+%= button_to 'Third' => '/' => (class => 'menu')
+%= button_to 'Fourth' => 'http://example.com'
+
 @@ script.html.ep
 <%= javascript '/script.js' %>
 <%= javascript begin %>