Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: metacpan/metacpan-client
base: 8ff2f08299c3
Choose a base ref
...
head repository: metacpan/metacpan-client
compare: c3075ad97f1d
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 27, 2014

  1. GH #2: remove unnecessary validation of _get_or_search: 

    In the method _get_or_search there's validation for a proper class
name. However, as described by rafl in the Github issue, it is both
incorrect and unnecessary.

There are both valid classes (for modules, distributions, and
releases) that won't pass the tests, and invalid classes which will
pass the test.

While it stands to reason to validate input before it is sent to
MetaCPAN, it is simply impractical to do this since the nature of
class names in Perl is... unfun to handle.

Therefor, we are only checking whether it's defined and not a
reference. If so, we pass it along to MetaCPAN. Enjoy.
    @xsawyerx
    xsawyerx committed Apr 27, 2014
    Copy the full SHA
    3848e03 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/remove-unnecessary-validation'

    @xsawyerx
    xsawyerx committed Apr 27, 2014
    Copy the full SHA
    c3075ad View commit details
    Browse the repository at this point in the history