Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
tools: remove "addon.gypi" and "gyp_addon"
Browse files Browse the repository at this point in the history
They've been merged into `node-gyp` and aren't serving any purpose
in the node repo. Fixes #3760.
  • Loading branch information
TooTallNate committed Aug 12, 2012
1 parent 320ae69 commit 00fa886
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 66 deletions.
24 changes: 0 additions & 24 deletions tools/addon.gypi

This file was deleted.

42 changes: 0 additions & 42 deletions tools/gyp_addon

This file was deleted.

6 comments on commit 00fa886

@ry
Copy link

@ry ry commented on 00fa886 Aug 13, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@jbergstroem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi, this breaks the buildbots: http://buildbot.nodejs.org/builders/Gentoo%2032bit/builds/2426/steps/shell_2/logs/stdio. Probably need to update the build receipt?

@TooTallNate
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbergstroem That was more or less a bug in node-gyp. v0.6.5 fixed it.

@jbergstroem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TooTallNate Ok, but why is it still happening (that build was against commit 22804a9)?

@TooTallNate
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess because @isaacs hasn't updated the bundled version of node-gyp inside npm to that version yet.

@jbergstroem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figures, thanks. I pinged him on irc an hour ago, lets see what happens :-)

Please sign in to comment.