This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tools: remove "addon.gypi" and "gyp_addon"
They've been merged into `node-gyp` and aren't serving any purpose in the node repo. Fixes #3760.
- Loading branch information
00fa886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
00fa886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi, this breaks the buildbots: http://buildbot.nodejs.org/builders/Gentoo%2032bit/builds/2426/steps/shell_2/logs/stdio. Probably need to update the build receipt?
00fa886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbergstroem That was more or less a bug in node-gyp. v0.6.5 fixed it.
00fa886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TooTallNate Ok, but why is it still happening (that build was against commit 22804a9)?
00fa886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess because @isaacs hasn't updated the bundled version of node-gyp inside npm to that version yet.
00fa886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figures, thanks. I pinged him on irc an hour ago, lets see what happens :-)