Skip to content
This repository was archived by the owner on Sep 30, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/vienna
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b9fc9bbc3494
Choose a base ref
...
head repository: opal/vienna
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 94351dc75505
Choose a head ref
  • 6 commits
  • 9 files changed
  • 1 contributor

Commits on Dec 7, 2014

  1. Add bundler gem management tasks

    @elia
    elia committed Dec 7, 2014

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    2f9dbb9 View commit details

  2. Remove Ruby 1.8.7 support

    @elia
    elia committed Dec 7, 2014
    Copy the full SHA
    82e3bcf View commit details

  3. Remove test that was base on bad semantics 

    The only thing that an assignment can return is the assigned object itself. Any return value is discarded by design.
    @elia
    elia committed Dec 7, 2014
    Copy the full SHA
    3096444 View commit details

  4. Use latest opal-rspec

    @elia
    elia committed Dec 7, 2014
    Copy the full SHA
    936f748 View commit details

  5. Whitespace

    @elia
    elia committed Dec 7, 2014
    Copy the full SHA
    2ae5ccc View commit details

  6. Move everything under Opal namespace

    @elia
    elia committed Dec 7, 2014
    Copy the full SHA
    94351dc View commit details
Showing with 13 additions and 15 deletions.
  1. +0 −1 .travis.yml
  2. +1 −1 Gemfile
  3. +2 −1 Rakefile
  4. +1 −0 lib/opal-vienna.rb
  5. +2 −2 lib/{ → opal}/vienna.rb
  6. +5 −0 lib/opal/vienna/version.rb
  7. +0 −3 lib/vienna/version.rb
  8. +2 −2 opal-vienna.gemspec
  9. +0 −5 spec/observable_spec.rb
1 change: 0 additions & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
language: ruby

rvm:
- 1.8.7
- 1.9.3
- 2.0.0

2 changes: 1 addition & 1 deletion Gemfile
View file
Original file line number Diff line number Diff line change
@@ -4,4 +4,4 @@ gemspec
gem 'opal'
gem 'opal-jquery', :github => 'opal/opal-jquery'
gem 'opal-activesupport', :github => 'opal/opal-activesupport'
gem 'opal-rspec', '0.3.0.beta2'
gem 'opal-rspec', '0.4.0.beta4'
3 changes: 2 additions & 1 deletion Rakefile
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
require 'bundler'
Bundler.require
require 'opal/activesupport'
Bundler::GemHelper.install_tasks

require 'opal/activesupport'
require 'opal/rspec/rake_task'
Opal::RSpec::RakeTask.new(:default)
1 change: 1 addition & 0 deletions lib/opal-vienna.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
require 'opal/vienna'
4 changes: 2 additions & 2 deletions lib/vienna.rb → lib/opal/vienna.rb
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'opal'
require 'opal-jquery'
require 'opal-activesupport'
require 'vienna/version'
require 'opal/vienna/version'

# Just register our opal code path with opal build tools
Opal.append_path File.expand_path('../../opal', __FILE__)
Opal.append_path File.expand_path('../../../opal', __FILE__)
5 changes: 5 additions & 0 deletions lib/opal/vienna/version.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module Opal
module Vienna
VERSION = '0.7.0'
end
end
3 changes: 0 additions & 3 deletions lib/vienna/version.rb
View file

This file was deleted.

4 changes: 2 additions & 2 deletions opal-vienna.gemspec
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# -*- encoding: utf-8 -*-
$LOAD_PATH << File.expand_path('../lib', __FILE__)
require 'vienna/version'
require 'opal/vienna/version'

Gem::Specification.new do |s|
s.name = 'opal-vienna'
s.version = Vienna::VERSION
s.version = Opal::Vienna::VERSION
s.author = 'Adam Beynon'
s.email = 'adam@adambeynon.com'
s.homepage = 'http://opalrb.org'
5 changes: 0 additions & 5 deletions spec/observable_spec.rb
View file
Original file line number Diff line number Diff line change
@@ -27,11 +27,6 @@ def bar=(b)
object.baz.should eq(110)
end

it "returns the value from the original method" do
object.replace_writer_for(:bar)
(object.bar = 32).should eq("#bar")
end

it "does not add a setter unless an existing attribute= method exists" do
object.replace_writer_for(:bob)
object.should_not respond_to(:bob=)