Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b28adbfa0552
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 49d3785c7da4
Choose a head ref
  • 2 commits
  • 14 files changed
  • 1 contributor

Commits on Mar 27, 2015

  1. Copy the full SHA
    377baba View commit details
  2. Copy the full SHA
    49d3785 View commit details
5 changes: 0 additions & 5 deletions spec/truffle/tags/core/encoding/converter/convert_tags.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,2 @@
fails:Encoding::Converter#convert returns a String
fails:Encoding::Converter#convert sets the encoding of the result to the target encoding
fails:Encoding::Converter#convert transcodes the given String to the target encoding
fails:Encoding::Converter#convert allows Strings of different encodings to the source encoding
fails:Encoding::Converter#convert reuses the given encoding pair if called multiple times
fails:Encoding::Converter#convert raises UndefinedConversionError if the String contains characters invalid for the target encoding
fails:Encoding::Converter#convert raises an ArgumentError if called on a finished stream
1 change: 0 additions & 1 deletion spec/truffle/tags/core/encoding/converter/inspect_tags.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
fails:Encoding::Converter#inspect needs to be reviewed for spec completeness
fails:Encoding::Converter#inspect includes the source and destination encodings in the return value
4 changes: 0 additions & 4 deletions spec/truffle/tags/core/encoding/converter/last_error_tags.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
fails:Encoding::Converter#last_error returns nil when the no conversion has been attempted
fails:Encoding::Converter#last_error returns nil when the last conversion did not produce an error
fails:Encoding::Converter#last_error returns nil when #primitive_convert last returned :destination_buffer_full
fails:Encoding::Converter#last_error returns nil when #primitive_convert last returned :finished
fails:Encoding::Converter#last_error returns nil if the last conversion succeeded but the penultimate failed
fails:Encoding::Converter#last_error returns an Encoding::InvalidByteSequenceError when #primitive_convert last returned :invalid_byte_sequence
fails:Encoding::Converter#last_error returns an Encoding::UndefinedConversionError when #primitive_convert last returned :undefined_conversion
3 changes: 0 additions & 3 deletions spec/truffle/tags/core/encoding/converter/new_tags.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
fails:Encoding::Converter.new accepts an Encoding object for the source encoding
fails:Encoding::Converter.new accepts an Encoding object for the destination encoding
fails:Encoding::Converter.new calls #to_str to convert the source encoding argument to an encoding name
fails:Encoding::Converter.new calls #to_str to convert the destination encoding argument to an encoding name
fails:Encoding::Converter.new calls #to_hash to convert the options argument to a Hash if not a Fixnum
Original file line number Diff line number Diff line change
@@ -1,31 +1,4 @@
fails:Encoding::Converter#primitive_convert accepts a nil source buffer
fails:Encoding::Converter#primitive_convert accepts a String as the source buffer
fails:Encoding::Converter#primitive_convert accepts nil for the destination byte offset
fails:Encoding::Converter#primitive_convert accepts an integer for the destination byte offset
fails:Encoding::Converter#primitive_convert calls #to_int to convert the destination byte offset
fails:Encoding::Converter#primitive_convert raises an ArgumentError if the destination byte offset is greater than the bytesize of the destination buffer
fails:Encoding::Converter#primitive_convert uses the destination byte offset to determine where to write the result in the destination buffer
fails:Encoding::Converter#primitive_convert accepts nil for the destination bytesize
fails:Encoding::Converter#primitive_convert accepts an integer for the destination bytesize
fails:Encoding::Converter#primitive_convert allows a destination bytesize value greater than the bytesize of the source buffer
fails:Encoding::Converter#primitive_convert allows a destination bytesize value less than the bytesize of the source buffer
fails:Encoding::Converter#primitive_convert calls #to_int to convert the destination byte size
fails:Encoding::Converter#primitive_convert uses destination bytesize as the maximumn bytesize of the destination buffer
fails:Encoding::Converter#primitive_convert allows a destination buffer of unlimited size if destination bytesize is nil
fails:Encoding::Converter#primitive_convert accepts an options hash
fails:Encoding::Converter#primitive_convert sets the destination buffer's encoding to the destination encoding if the conversion suceeded
fails:Encoding::Converter#primitive_convert sets the destination buffer's encoding to the destination encoding if the conversion failed
fails:Encoding::Converter#primitive_convert removes the undefined part from the source buffer when returning :undefined_conversion
fails:Encoding::Converter#primitive_convert returns :incomplete_input when source buffer ends unexpectedly and :partial_input isn't specified
fails:Encoding::Converter#primitive_convert clears the source buffer when returning :incomplete_input
fails:Encoding::Converter#primitive_convert returns :source_buffer_empty when source buffer ends unexpectedly and :partial_input is true
fails:Encoding::Converter#primitive_convert clears the source buffer when returning :source_buffer_empty
fails:Encoding::Converter#primitive_convert returns :undefined_conversion when a character in the source buffer is not representable in the output encoding
fails:Encoding::Converter#primitive_convert returns :invalid_byte_sequence when an invalid byte sequence was found in the source buffer
fails:Encoding::Converter#primitive_convert removes consumed and erroneous bytes from the source buffer when returning :invalid_byte_sequence
fails:Encoding::Converter#primitive_convert returns :finished when the conversion succeeded
fails:Encoding::Converter#primitive_convert clears the source buffer when returning :finished
fails:Encoding::Converter#primitive_convert returns :destination_buffer_full when the destination buffer is too small
fails:Encoding::Converter#primitive_convert clears the source buffer when returning :destination_buffer_full
fails:Encoding::Converter#primitive_convert keeps removing invalid bytes from the source buffer
fails:Encoding::Converter#primitive_convert reuses read-again bytes after the first error
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
fails:Encoding::Converter#primitive_errinfo returns [:finished,nil,nil,nil,nil] when #primitive_convert last returned :finished
fails:Encoding::Converter#primitive_errinfo returns [:source_buffer_empty,nil,nil,nil, nil] when #convert last succeeded
fails:Encoding::Converter#primitive_errinfo returns [:destination_buffer_full,nil,nil,nil,nil] when #primitive_convert last returned :destination_buffer_full
fails:Encoding::Converter#primitive_errinfo returns the status of the last primitive conversion, even if it was successful and the previous one wasn't
fails:Encoding::Converter#primitive_errinfo returns the state, source encoding, target encoding, and the erroneous bytes when #primitive_convert last returned :undefined_conversion
fails:Encoding::Converter#primitive_errinfo returns the state, source encoding, target encoding, and erroneous bytes when #primitive_convert last returned :incomplete_input
fails:Encoding::Converter#primitive_errinfo returns the state, source encoding, target encoding, erroneous bytes, and the read-again bytes when #primitive_convert last returned :invalid_byte_sequence
fails:Encoding::Converter#primitive_errinfo returns the state, source encoding, target encoding, erroneous bytes, and the read-again bytes when #convert last raised InvalidByteSequenceError
fails:Encoding::Converter#primitive_errinfo returns the state, source encoding, target encoding, erroneous bytes, and the read-again bytes when #finish last raised InvalidByteSequenceError
Original file line number Diff line number Diff line change
@@ -6,9 +6,3 @@ slow:Encoding::Converter.search_convpath sets the last element of each pair to t
slow:Encoding::Converter.search_convpath only lists a source encoding once
slow:Encoding::Converter.search_convpath indicates if crlf_newline conversion would occur
slow:Encoding::Converter.search_convpath raises an Encoding::ConverterNotFoundError if no conversion path exists
fails:Encoding::Converter.search_convpath returns an Array
fails:Encoding::Converter.search_convpath returns each encoding pair as a sub-Array
fails:Encoding::Converter.search_convpath returns each encoding as an Encoding object
fails:Encoding::Converter.search_convpath returns multiple encoding pairs when direct conversion is impossible
fails:Encoding::Converter.search_convpath sets the last element of each pair to the first element of the next
fails:Encoding::Converter.search_convpath only lists a source encoding once
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
fails:Encoding::InvalidByteSequenceError#incomplete_input? returns true if #primitive_convert returned :incomplete_input for the same data
fails:Encoding::InvalidByteSequenceError#incomplete_input? returns false if #primitive_convert returned :invalid_byte_sequence for the same data
1 change: 0 additions & 1 deletion spec/truffle/tags/core/string/append_tags.txt

This file was deleted.

1 change: 0 additions & 1 deletion spec/truffle/tags/core/string/clear_tags.txt

This file was deleted.

1 change: 0 additions & 1 deletion spec/truffle/tags/core/string/concat_tags.txt

This file was deleted.

3 changes: 0 additions & 3 deletions spec/truffle/tags/core/string/encoding_tags.txt

This file was deleted.

1 change: 0 additions & 1 deletion spec/truffle/tags/core/string/start_with_tags.txt

This file was deleted.

1 change: 0 additions & 1 deletion spec/truffle/tags/core/string/upto_tags.txt

This file was deleted.