Skip to content

Hologram produces light even when no power #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aschmois opened this issue Mar 29, 2015 · 7 comments
Closed

Hologram produces light even when no power #979

aschmois opened this issue Mar 29, 2015 · 7 comments
Milestone

Comments

@aschmois
Copy link

I'm trying to make my entire base electricity powered but the hologram produces light regardless if pc is on or off (or if there's even electricity). This makes it impossible to turn the lights off in a room. Would love it if you guys could add a config to lighting on a hologram. If it was up to me, I'd always leave lighting off for the hologram (I have other lighting solutions anyways).

@fnuecke
Copy link
Member

fnuecke commented Mar 29, 2015

This is due to the limitations of the rather static lighting system in Minecraft. To properly change the hologram's light level (or any block in OC emitting light, such as screens and assemblers), I'd have to trigger an update for all blocks that are in the lit radius of the block. Which is pretty much a performance nightmare, since whether these blocks should emit light / are on can change very rapidly.

What you can do is "hide" the hologram under another block that blocks its light, and adjust for that via hologram.setTranslation().

@fnuecke fnuecke closed this as completed Mar 29, 2015
@gjgfuj
Copy link

gjgfuj commented Mar 29, 2015

But other mods do it for their things, and yes, a player could do that, and
slow down the server, but there's a lot easier things to do to slow down a
server.

On Sun, 29 Mar 2015 10:07 pm fnuecke notifications@github.com wrote:

This is due to the limitations of the rather static lighting system in
Minecraft. To properly change the hologram's light level (or any block in
OC emitting light, such as screens and assemblers), I'd have to trigger an
update for all blocks that are in the lit radius of the block. Which is
pretty much a performance nightmare, since whether these blocks should emit
light / are on can change very rapidly.

What you can do is "hide" the hologram under another block that blocks its
light, and adjust for that via hologram.setTranslation().


Reply to this email directly or view it on GitHub
#979 (comment)
.

@fnuecke
Copy link
Member

fnuecke commented Mar 29, 2015

Well, there is also the fact that the last time I actually did have a go at it lighting broke left and right, because MC's lighting engine is ... not the best, to put it absolutely undeservedly diplomatic. Specifically, solid blocks' lighting does not properly update. So for holograms I suppose that could work, for screens it simply won't.

To verify this is a vanilla bug, take a redstone ore block, place a torch on it, then remove the torch again. You'll see the light level around the block remains that of the torch, which is higher than that of the redstone ore block.

I'll leave it open for now, but no promises.

@aschmois
Copy link
Author

What about an on/off config option? Just remove lighting for this block altogether?

@fnuecke
Copy link
Member

fnuecke commented Mar 29, 2015

If I add it / get it to work it'll probably something along the lines of a three-way option: true, false and auto.

@aschmois
Copy link
Author

Yeah that's perfect but, knowing too much about mc's lighting, you're definitely going to have a hard time, and if it just becomes too much I feel like just having on/off option is a lot easier than automatic. So if all else fails that should be enough for some people :)

@fnuecke
Copy link
Member

fnuecke commented Mar 29, 2015

Well, in the worst-case scenario, that'd still be an option. I agree ;-)

Sorry, something went wrong.

@fnuecke fnuecke added this to the v1.5.20 milestone Nov 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants