Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding userID and userAgent to events #760

Merged
merged 2 commits into from Apr 1, 2015
Merged

Adding userID and userAgent to events #760

merged 2 commits into from Apr 1, 2015

Conversation

escowles
Copy link
Contributor

ajs6f
ajs6f reviewed Apr 1, 2015
View reviewed changes
fcrepo-http-api/src/main/java/org/fcrepo/http/api/FedoraBaseResource.java
**/
protected void setUpJMSBaseURIs(final UriInfo uriInfo) {
protected void setUpJMSBaseURIs(final UriInfo uriInfo, final HttpHeaders headers) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method name still accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rename it to something like setUpJMSInfo.

@escowles
Renaming setUpJMSBaseURIs to setUpJMSInfo, narrowing exception handli…
17f3ee6 
…ng, and using Gson instead of building JSON as a string
ajs6f added a commit that referenced this pull request Apr 1, 2015
@ajs6f
Merge pull request #760 from fcrepo4/event-info
f374e80 
Adding userID and userAgent to events
@ajs6f ajs6f merged commit f374e80 into master Apr 1, 2015
@ajs6f ajs6f deleted the event-info branch April 1, 2015 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@escowles @ajs6f @barmintor @awoods