Skip to content

Forge b1344 breaks OpenComputers #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kreezxil opened this issue Mar 28, 2015 · 9 comments
Closed

Forge b1344 breaks OpenComputers #975

kreezxil opened this issue Mar 28, 2015 · 9 comments

Comments

@kreezxil
Copy link

OpenComputers-MC1.8-1.5.4.9-universal.jar
and prior exhibit the following under the new Forge b1344

Multiple entries with same key:
Crash Report: http://pastebin.com/6iYAAmeT
FML Server Latest: http://pastebin.com/aA3EAfpD

@MyNameIsKodos
Copy link
Contributor

From what I can tell you're using two copies of the OC jar...

@gamax92
Copy link
Contributor

gamax92 commented Mar 28, 2015

Oddly, the same jar file "OpenComputers-MC1.8-1.5.4.9-universal.jar" gets listed twice in the mod list

Sorry, something went wrong.

@MyNameIsKodos
Copy link
Contributor

Ah, that's odd.

Sorry, something went wrong.

@fnuecke
Copy link
Member

fnuecke commented Mar 28, 2015

Ugh, I'm pretty sure this is due to the... fix, that now makes FML also check inner classes. Because when Scala compiles singletons it applies annotations on the object to both the static proxy and the actual class. So now any mod using Scala for it's main @Mod class will probably have that issue. I'll see how I can work around it, and probably open an issue on FML to ask if there's a chance they'll fix the fix / add a special check to avoid this.

Sorry, something went wrong.

@kreezxil
Copy link
Author

Cool. I've also reported it there. Hopefully they will give it more concern when you open your ticket there.

Btw, b1341 behaves properly with your mod.

-----Original Message-----
From: "fnuecke" notifications@github.com
Sent: ‎3/‎28/‎2015 3:58 AM
To: "MightyPirates/OpenComputers" OpenComputers@noreply.github.com
Cc: "kreezxil" kreezxil@gmail.com
Subject: Re: [OpenComputers] Forge b1344 breaks OpenComputers (#975)

Ugh, I'm pretty sure this is due to the... fix, that now makes FML also check inner classes. Because when Scala compiles singletons it applies annotations on the object to both the static proxy and the actual class. So now any mod using Scala for it's main @mod class will probably have that issue. I'll see how I can work around it, and probably open an issue on FML to ask if there's a chance they'll fix the fix / add a special check to avoid this.

Reply to this email directly or view it on GitHub.

@fnuecke
Copy link
Member

fnuecke commented Mar 28, 2015

Reported my findings, looks like someone's on it!

@kreezxil
Copy link
Author

I just got word from diesenb07 at Minecraft forge that it is a bug in fml and they'll push a pr to fix the issue.

-----Original Message-----
From: "fnuecke" notifications@github.com
Sent: ‎3/‎28/‎2015 3:58 AM
To: "MightyPirates/OpenComputers" OpenComputers@noreply.github.com
Cc: "kreezxil" kreezxil@gmail.com
Subject: Re: [OpenComputers] Forge b1344 breaks OpenComputers (#975)

Ugh, I'm pretty sure this is due to the... fix, that now makes FML also check inner classes. Because when Scala compiles singletons it applies annotations on the object to both the static proxy and the actual class. So now any mod using Scala for it's main @mod class will probably have that issue. I'll see how I can work around it, and probably open an issue on FML to ask if there's a chance they'll fix the fix / add a special check to avoid this.

Reply to this email directly or view it on GitHub.

@fnuecke
Copy link
Member

fnuecke commented Mar 28, 2015

👍

@fnuecke
Copy link
Member

fnuecke commented Mar 29, 2015

Fix has been merged into FML, so this should resolve itself once Forge updates FML.

@fnuecke fnuecke closed this as completed Mar 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants