Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked in fcrepo-auth-oauth #90

Merged
merged 4 commits into from Jul 4, 2013
Merged

Linked in fcrepo-auth-oauth #90

merged 4 commits into from Jul 4, 2013

Conversation

ajs6f
Copy link
Contributor

@ajs6f ajs6f commented Jul 1, 2013

No description provided.

@cbeer
Copy link
Contributor

cbeer commented Jul 1, 2013

Let me question this once more... does this really belong in fcrepo-webapp and not kitchen sink?

@ajs6f
Copy link
Contributor Author

ajs6f commented Jul 1, 2013

I think it does not, but @eddies specifically told me otherwise.

@cbeer
Copy link
Contributor

cbeer commented Jul 1, 2013

@eddies, who's that? isn't he off the project now?

@ajs6f
Copy link
Contributor Author

ajs6f commented Jul 1, 2013

@eddies: Is this a piece of functionality from the steering group reqs?

@cbeer
Copy link
Contributor

cbeer commented Jul 1, 2013

@ajs6f can you merge fcrepo-auth-oauth into the fcrepo4 repository? if we're actually baking this in (and @eddies has convinced me that we should), it should live close-to-core rather than our only free-floating dependency.

@ajs6f
Copy link
Contributor Author

ajs6f commented Jul 1, 2013

I can, but would we rather do a Git submodule? I'm really going to try to be a bear about trying to break up the main fcrepo4 repo. We agreed a long time ago to try to separate it for flexibility.

@ajs6f
Copy link
Contributor Author

ajs6f commented Jul 1, 2013

Actually, do we want to move towards breaking up fcrepo4 entirely and doing git submodules under fcrepo-webapp, so that you can just clone fcrepo-webapp and build?

@eddies
Copy link

eddies commented Jul 1, 2013

For now, no, let's not try to break up fcrepo4 any more before OR. And submodules are more confusing than they're worth IMHO (esp. for other users)

@ajs6f
Copy link
Contributor Author

ajs6f commented Jul 1, 2013

So… move fcrepo-auth-oauth under fcrepo4? Okay, I'll do that tomorrow.

@cbeer
Copy link
Contributor

cbeer commented Jul 1, 2013

And for completeness, here's the part of @eddies' argument that convinced me:

if we don't have an authz framework baked into core, nothing will drive the development that's needed to support generic authz features. The only auth implementation we have now that's worth anything is oauth, so let's ship it. (sure, we have the container-level auth that may or may not work with the native JCR stuff.. but we know we want more granular policies than that..). Hopefully that'll be enough to annoy us to e.g. hard-coding an authorized path into the webapp config and someone will fix it.

he also had nice things to say about oauth, but i'm not sure i believe them yet.

@barmintor
Copy link
Contributor

This stuff all looks pretty familiar. We can fiddle with injection strategies pre-Beta.

barmintor added a commit that referenced this pull request Jul 4, 2013
@barmintor barmintor merged commit 103ed4c into master Jul 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants