Fix #equal? for numeric, boolean and strings. Add Kernel#equal? specs

opal · Oct 29, 2013 · ab65e84 · ab65e84
1 parent 5352a03
commit ab65e84
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/corelib/boolean.rb b/corelib/boolean.rb
@@ -21,6 +21,8 @@ def ==(other)
     `(self == true) === other.valueOf()`
   end
 
+  alias equal? ==
+
   alias singleton_class class
 
   def to_s

diff --git a/corelib/numeric.rb b/corelib/numeric.rb
@@ -267,6 +267,7 @@ def downto(finish, &block)
   end
 
   alias eql? ==
+  alias equal? ==
 
   def even?
     `self % 2 === 0`

diff --git a/spec/filters/bugs/kernel.rb b/spec/filters/bugs/kernel.rb
@@ -7,4 +7,6 @@
   fails "Kernel#<=> returns 0 if self is == to the argument"
   fails "Kernel#<=> returns nil if self is eql? but not == to the argument"
   fails "Kernel#<=> returns nil if self.==(arg) returns nil"
+
+  fails "Kernel#equal? returns true only if obj and other are the same object"
 end
diff --git a/spec/rubyspec/core/kernel/equal_spec.rb b/spec/rubyspec/core/kernel/equal_spec.rb
diff --git a/spec/rubyspecs b/spec/rubyspecs
@@ -194,6 +194,7 @@ core/hash/values_spec
 
 core/kernel/comparison_spec
 core/kernel/eql_spec
+core/kernel/equal_spec
 
 core/matchdata/to_a_spec