Update unit testing environment to use mocks #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 12, 2012 12:03
integration test - TRUNK-3586
integration test classes when checking for Test classes that don't end with Test or IT - TRUNK-3586
ConceptMapTypeValidatorIT - TRUNK-3586
| @@ -285,7 +314,11 @@ public void shouldNotAllowTaskExecuteToRunBeforeInitializationIsComplete() throw | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * TODO This should be an integration test, get rid of it | |||
There was a problem hiding this comment.
Okay, so do get rid of it instead of putting @ignore. :-)
ghost
assigned 
| @Before | ||
| public void before() { | ||
| MessageSourceService as = mock(MessageSourceService.class); | ||
| PowerMockito.stub(PowerMockito.method(Context.class, "getMessageSourceService")).toReturn(as); |
There was a problem hiding this comment.
You should be able to use plain Mockito here: Mockito.when(Context.getMessageSourceService()).thenReturn(as);
There was a problem hiding this comment.
The thing is that i need to mock some methods at the sametime invoke the actual code in some and at the same time i want some not to be called at all, to achieve this, i need to use stub for specific methods otherwise i will end up having the code cluttered with calls like Mockito.spy, Mockito.doCallRealMethod and Mockito.doNothing everywhere, i basically found stub much cleaner.
|
SonarCloud Quality Gate failed. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
…on -> frontend.json (openmrs#120) * Add support for JSON parameterization of build. And microfrontends.json -> frontend.json * Prettier * frontend.json --> spa-build-config.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.openmrs.org/browse/TRUNK-3586