Item13335: apply .spec files when saving configuration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, .spec files would only be applied during bootstrapping. This means that when users install extensions after bootstrapping, it is difficult to apply the extension's Config.spec file. In order to make this work, the order in which Foswiki::Configure::Load reads the files needed to change: previously, Config.spec files were applied after applying LocalSite.cfg, thus overriding the values stored there. The new code loads the files in the following order: Foswiki.spec, Config.spec files, LocalSite.cfg.
jast
added a commit
that referenced
this pull request
Mar 27, 2015
Item13335: apply .spec files when saving configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, .spec files would only be applied during bootstrapping. This means
that when users install extensions after bootstrapping, it is difficult to
apply the extension's Config.spec file.
In order to make this work, the order in which Foswiki::Configure::Load reads
the files needed to change: previously, Config.spec files were applied after
applying LocalSite.cfg, thus overriding the values stored there. The new code
loads the files in the following order: Foswiki.spec, Config.spec files,
LocalSite.cfg.