This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
Impl mapping for solr fields #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I will review this PR this evening... and hopefully merge. |
|
Thanks! |
| LOGGER.debug("Parsed SolrInputDocument: {}", inputDoc); | ||
| doc.close(); | ||
|
|
||
| // add the identifier of the resource as a unique index-key | ||
| inputDoc.addField("id", pid); |
There was a problem hiding this comment.
At some point, we should probably make the unique key field configurable. Not important for this PR, but..
There was a problem hiding this comment.
Agreed. I think of two stages:
- Spring-config'd ID. I can add another commit if you think it worthwhile.
- Indexer reads the Solr schema and inspects for unique ID as well as other interesting info. (Much later.)
There was a problem hiding this comment.
Doing 1 would be nice of us, but not essential. If it's a 5 minute change, I'd say do it. If it's harder than that, ship it?
document (Solr document) based on messaging emitted from an F4 repository Implement customizable search index design (https://wiki.duraspace.org/display/FF/Design+-+Customizable+Search+Index) Also, allow asynchronous or synchronous indexing patterns for both Solr and SPARQL indexing.
|
Squashed. I'm going to let travis check the build and then merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for
https://www.pivotaltracker.com/story/show/61894388