TRUNK-3959 - TRUNK-3955 #271
Closed
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….plugin.system.issuetabpanels:all-tabpanel
|
Could you please correct a commit message in gordonbr@ce561b3 ? Include just a ticket id and a title. For the future please do not send pull requests from your master branch, but create a topic branch for each ticket. |
|
Could you please claim issues in JIRA as well? |
ghost
assigned 
|
Good point Daniel about using StringUtils, i will make the change and push the code to master |
| @@ -192,7 +192,7 @@ public Cohort generatePatientSet(EvaluationContext context) { | |||
| cohort = new Cohort(getPatientIds()); | |||
| } | |||
|
|
|||
| if (location != null && !location.equals("")) { | |||
| if (location != null && !location.equals(new Location())) { | |||
There was a problem hiding this comment.
I think Daniel is correct, i think having !location.equals(new Location()) here is pointless, is it meant to check that location.name is not empty?
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed this bug just replacing != for .equals with the correct logic.
In the trunk 3955 I've change to pass a new Location instead of a string "".