Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 64399dd8782f
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 7b07e9f7ea01
Choose a head ref
  • 13 commits
  • 11 files changed
  • 7 contributors

Commits on Mar 5, 2015

  1. http: fix performance regression for GET requests

    A significant performance regressions has been introduced in 1fddc1f for
    GET requests which send data through response.end(). The number of
    requests per second dropped to somewhere around 6% of their previous
    level.
    
    The fix consists of removing a part of the lines added by 1fddc1f,
    lines which were supposed to affect only HEAD requests, but interfered
    with GET requests instead.
    
    The lines removed would not have affected the behaviour in the case of
    a HEAD request as this._hasBody would always be false. Therefore, they
    were not required to fix the issue reported in #8361.
    
    Fixes #8940.
    
    PR: #9026
    PR-URL: #9026
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    CGavrila authored and Julien Gilli committed Mar 5, 2015
    Copy the full SHA
    8bcd0a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2015

  1. deps: update libuv to 0.10.36

    PR: #9274
    PR-URL: #9274
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    saghul authored and Julien Gilli committed Mar 6, 2015
    Copy the full SHA
    dcff5d5 View commit details
    Browse the repository at this point in the history
  2. url: revert reslove urls with . and ..

    This reverts commit ad06848.
    
    Initially, this bug fix targeted master, and I pushed to have it
    included in v0.10. In retrospect, I'm not sure it should have made into
    v0.10 as it seems it could break a lot of existing working code.
    
    In my opinion, this change is still a bug fix, and it is not backward
    incompatible per se. However, I'm not sure that taking the risk to break
    a lot of users with a new 0.10.x release that would include this fix is
    reasonable, especially now that 0.10.x releases are entering
    maintenance mode.
    
    PR-URL: #9257
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Julien Gilli committed Mar 6, 2015
    Copy the full SHA
    a5be84f View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2015

  1. docs: add return value for sync fs functions

    Clarify that synchronous functions in fs with no return value return
    undefined.
    
    Specify that fs.openSync() returns an integer and fs.existsSync()
    returns true or false.
    
    Fixes #9313
    
    PR: #9359
    PR-URL: #9359
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    Ly0ko authored and Julien Gilli committed Mar 10, 2015
    Copy the full SHA
    51fe319 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2015

  1. domains: fix stack clearing after error handled

    caeb677 introduced a regression where
    the domains stack would not be cleared after an error had been handled
    by the top-level domain.
    
    This change clears the domains stack regardless of the position of the
    active domain in the stack.
    
    PR: #9364
    PR-URL: #9364
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    dohse authored and Julien Gilli committed Mar 11, 2015
    Copy the full SHA
    f2a45ca View commit details
    Browse the repository at this point in the history
  2. build: allow custom PackageMaker path

    Make PACKAGEMAKER customizable because PackageMaker is not necessarily
    installed in /Developer on OSX anymore.
    
    PR: #9377
    PR-URL: #9377
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    Julien Gilli committed Mar 11, 2015
    Copy the full SHA
    219c80d View commit details
    Browse the repository at this point in the history
  3. 2015.03.11, Version 0.10.37 (Maintenance)

    * uv: update to 0.10.36 (CVE-2015-0278)
    
    * domains: fix stack clearing after error handled (Jonas Dohse)
    
    * buffer: reword Buffer.concat error message (Chris Dickinson)
    
    * console: allow Object.prototype fields as labels (Julien Gilli)
    
    * V8: log version in profiler log file (Ben Noordhuis)
    
    * http: fix performance regression for GET requests (Florin-Cristian Gavrila)
    Julien Gilli committed Mar 11, 2015
    Copy the full SHA
    7d6b5b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2015

  1. Merge branch 'v0.10.37-release' into v0.10

    Julien Gilli committed Mar 12, 2015
    Copy the full SHA
    50c23fb View commit details
    Browse the repository at this point in the history
  2. Now working on 0.10.38

    Julien Gilli committed Mar 12, 2015
    Copy the full SHA
    4332c77 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2015

  1. test: update flaky test definitions

    test-fs-watch is flaky on OSX.
    orangemocha committed Mar 13, 2015
    Copy the full SHA
    e8b2109 View commit details
    Browse the repository at this point in the history
  2. make: remove node_dtrace from cpplint excludes

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #8741
    Julien Gilli committed Mar 13, 2015
    Copy the full SHA
    588c009 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2015

  1. Merge remote-tracking branch 'upstream/v0.10' into v0.12

    Conflicts:
    	AUTHORS
    	ChangeLog
    	deps/uv/ChangeLog
    	deps/uv/build.mk
    	deps/uv/config-unix.mk
    	deps/uv/include/uv-private/uv-win.h
    	deps/uv/src/unix/async.c
    	deps/uv/src/unix/process.c
    	deps/uv/src/version.c
    	deps/uv/src/win/poll.c
    	deps/uv/test/test-list.h
    	deps/uv/uv.gyp
    	lib/http.js
    	src/node.js
    	src/node_version.h
    Julien Gilli committed Mar 16, 2015
    Copy the full SHA
    eb2764a View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2015

  1. test: address timing issues in simple http tests

    simple tests test-http-request-end.js, test-http-default-encoding.js
    hangs in AIX. The root cause for both the failures is related to the
    timing with which packets are sent between the client and server.
    On the client side, one factor that affects the timing is Nagle's
    algorithm. With Nagle enabled there may be a delay between two packets
    as the stack may wait until either:
      a. An acknowledgement for the first packet is received, or
      b. 200 ms elapses.
    before sending the second packet.
    
    Similarly at the server side 2 sequential packages can be delivered to
    the application either together or separatly.
    
    On AIX we see that they are delivered separately to the server, while on
    Linux delivered together. If we change the timing, for example disabling
    Nagle on AIX we see the 2 packets delivered together and the tests pass.
    
    In the test case simple/test-http-request-end.js, the client request
    handler of the server receives and stores the data in a data callback,
    closes the server in a request end callback, and writes to the client
    and ends the response, in-line with the request receipt. An HTTP parser
    module parses the incoming message, and invokes callback routines which
    are registered for HTTP events (such as header, body, end etc.)
    
    Because the termination sequence arrive in a separate packet, there is a
    delay in parsing that message and identify that the client request ended
    (and thereby invoke the request end call backhandler). Due to this delay,
    the response close happens first, which in-turn destroys the server
    socket leading to the fd and watcher removal from the uv loop abandoning
    further events on this connection, and end call back never being called,
    causing the reported hang.  simple/test-http-default-encoding.js suffers
    from the same problem.
    
    Also, remove the timer logic from the test case. Test harness anyways
    contain a timer which controls the individual tests so remove such
    controls from the test case, as suggested by @tjfontaine
    gireeshpunathil committed Mar 27, 2015
    Copy the full SHA
    7b07e9f View commit details
    Browse the repository at this point in the history