Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] Implementing Range in ruby. #2789

Merged
merged 1 commit into from Apr 1, 2015
Merged

[Truffle] Implementing Range in ruby. #2789

merged 1 commit into from Apr 1, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Mar 31, 2015

Could range be done in ruby?

There were two language specs that failed that I wasn’t sure how to fix.

@chrisseaton
Copy link
Contributor

At least Range#inject, #map, #each, #to_a and #collect are used in the fast path of benchmarks, so it will be tricky to get this right.

Try benchmarking this on matrix-multiply and spectral-norm to start with.

@chrisseaton chrisseaton added this to the truffle-dev milestone Mar 31, 2015
@bjfish bjfish force-pushed the truffle_range_ruby branch 4 times, most recently from 9535078 to b2a4f49 Compare April 1, 2015 16:20
@bjfish
Copy link
Contributor Author

bjfish commented Apr 1, 2015

Reverted to some of the Java specializations for benchmarks. Looks like about 100% for matrix-multiply and 150% for spectral-norm (not sure why there is a speed up). The failing language specs now pass.

chrisseaton added a commit that referenced this pull request Apr 1, 2015
@chrisseaton
Merge pull request #2789 from bjfish/truffle_range_ruby
04c7e9f 
[Truffle] Implementing Range in ruby.
@chrisseaton chrisseaton merged commit 04c7e9f into jruby:master Apr 1, 2015
@chrisseaton
Copy link
Contributor

Sorry, this caused regressions on psd-imagemode-greyscale-combine-greyscale-channel and chunky-canvas-resampling-stpes-residues. Can you take a look at those? They must use something else that still needs to be in Java.

@bjfish
Copy link
Contributor Author

bjfish commented Apr 1, 2015

@chrisseaton The benchmark should be fixed here: dc85f30

Please give it a try when you can. Thanks.

@chrisseaton
Copy link
Contributor

Yeah that fixed it - thanks again.

@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjfish @chrisseaton @enebo