[Truffle] Don't taint from self in String#[](String). #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could parameterise the exception - I don't mind the exception - they compile to a jump and using exceptions is idiomatic Truffle - unlike in normal Java code so no need to feel dirty. I guess an exception also simplifies the interaction with the DSL? I think a wrapper object would also be fine. Neither adds any peak runtime overhead. |
|
Looks good to me as the exception is contained in the TaintResultNode. |
|
This was news to me, but generic classes can't extend java.lang.Throwable. |
|
Ah yeah, I have come across that before. nm |
nirvdrum
added a commit
that referenced
this pull request
Mar 30, 2015
[Truffle] Don't taint from self in String#[](String).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisseaton @eregon This is one of the proposed solutions for dealing with the need to skip tainting for certain specializations. I don't particularly like using exceptions this way, but using a wrapper object would likely add much greater overhead. The third alternative is to not use the CoreMethod option for tainting at all, but rather have each specialization that needs it use the
TaintResultNodein place; this seems both error-prone (easy to forget one) and verbose.I'm doing this as a PR to get feedback. No hard feelings if you think this is terrible.