Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dd9cf5f96b43
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f8c218c53a06
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 26, 2015

  1. exclude OpenSSL test that connects to https://www.paypal.com/ and ass… 

    …umes ca_file

this is an artificial failure that very likely started hapenning due PP's site https updates

... fails the same way under MRI 1.9.3 :
```
OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:800:in `connect'
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:800:in `block in connect'
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/timeout.rb:55:in `timeout'
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/timeout.rb:100:in `timeout'
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:800:in `connect'
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:756:in `do_start'
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/lib/ruby/1.9.1/net/http.rb:745:in `start'
	from (irb):32
	from /opt/local/rvm/rubies/ruby-1.9.3-p551/bin/irb:12:in `<main>'
```
    @kares
    kares committed Mar 26, 2015
    Copy the full SHA
    184a4a2 View commit details

  2. remove empty OpenSSL test exclude files + un-exclude working ASN1 test

    @kares
    kares committed Mar 26, 2015
    Copy the full SHA
    f8c218c View commit details
1 change: 0 additions & 1 deletion test/externals/ruby1.9/excludes/OpenSSL/TestASN1.rb
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,6 @@
exclude :test_cons_implicit_tagging_inf_length, 'needs investigation'
exclude :test_cons_without_array_forbidden, 'needs investigation'
exclude :test_create_inf_length_primitive, 'needs investigation'
exclude :test_octet_string_infinite_length, 'needs investigation'
exclude :test_octet_string_infinite_length_explicit_tagging, 'needs investigation'
exclude :test_octet_string_infinite_length_implicit_tagging, 'needs investigation'
exclude :test_parse_empty_sequence, 'needs investigation'
Empty file removed test/externals/ruby1.9/excludes/OpenSSL/TestDigest.rb
View file
Empty file.
Empty file removed test/externals/ruby1.9/excludes/OpenSSL/TestX509Name.rb
View file
Empty file.
2 changes: 2 additions & 0 deletions test/externals/ruby1.9/excludes/TestIntegration.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# under openssl/test_integration.rb (not name-spaced as OpenSSL)
exclude :test_pathlen_does_not_appear, 'does https://www.paypal.com/ assumptions with ca_file'