Skip to content

Drone detection and false positivies #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MisterErwin opened this issue Mar 26, 2015 · 8 comments
Closed

Drone detection and false positivies #972

MisterErwin opened this issue Mar 26, 2015 · 8 comments
Milestone

Comments

@MisterErwin
Copy link

The drone's detect method returns false positives on blocks where a robot couln't pass through but a drone could, e.g. levers.

Here you can see the surrounding.

And here is a picture of the remote drone shell

Greetings and happy 3D modelling ;)

(I used version 1.5.4.471-dev, but according to the commits nothing was changed except some 3d stuff)

@fnuecke
Copy link
Member

fnuecke commented Mar 26, 2015

Well, "solid" technically just means it isn't air ;-)

Hmm, properly checking if a block is "passable" for a drone might be overkill, but I'll add a check whether a block returns no collision bounds at all, that should work for most scenarios (such as levers, buttons and torches).

@fnuecke fnuecke added this to the 1.5.4 milestone Mar 26, 2015
@fnuecke
Copy link
Member

fnuecke commented Mar 26, 2015

Done. Beware it'll still return true, "passable", so you'll have to check for that second value.

@MisterErwin
Copy link
Author

Thanks for fixing, but you might want to change that or the docs:

Returns: true if the robot if whatever is in front of the robot would prevent him from moving forward (a solid block or an entity), false otherwise.

See ocdoc.li

€: looks ;)

@fnuecke
Copy link
Member

fnuecke commented Mar 26, 2015

If I still remember it in a few minutes I will ;-) (You could also register and change it, wiki is open for registration and everyone can edit)

@MisterErwin
Copy link
Author

Work successfully outsourced ;)

But other than that, the block in front doesn't prevent the drone from moving, so shouldn't the boolean return be false?

But I'm going to add "passable" as soon as I get the master's answer ;)

@fnuecke
Copy link
Member

fnuecke commented Mar 26, 2015

Great, thanks ;)

The thing is, this is the same method for all agents - it's the exact same code that's used for robot.detect(). And those can't move in there. So for compatibility reasons and to avoid special cases this is how it is.

@MisterErwin
Copy link
Author

Report from slaved worker: D(r)one ;)

And thanks again

Sorry, something went wrong.

@fnuecke
Copy link
Member

fnuecke commented Mar 26, 2015

👍

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants