Move logic for default File "indexed" to lazy builder

The CPAN::Meta object being used to set the old default was being passed in anyway. This makes it much easier to add additional logic and seems like a less confusing place to have it.
metacpan · Mar 30, 2015 · b6889ff · b6889ff
1 parent 958d952
commit b6889ff
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/lib/MetaCPAN/Document/File.pm b/lib/MetaCPAN/Document/File.pm
@@ -300,7 +300,13 @@ has indexed => (
     required => 1,
     is       => 'rw',
     isa      => 'Bool',
-    default  => 1,
+    lazy     => 1,
+    default  => sub {
+        my ($self) = @_;
+        return 0 if $self->is_in_other_files;
+        return 0 if !$self->metadata->should_index_file( $self->path );
+        return 1;
+    },
 );
 
 =head2 level

diff --git a/lib/MetaCPAN/Model/Release.pm b/lib/MetaCPAN/Model/Release.pm
@@ -245,9 +245,7 @@ sub _build_files {
                     date         => $self->date,
                     directory    => $child->is_dir,
                     distribution => $self->distribution,
-                    indexed      => $self->metadata->should_index_file($fpath)
-                    ? 1
-                    : 0,
+
                     local_path => $child,
                     maturity   => $self->maturity,
                     metadata   => $self->metadata,

diff --git a/t/release/common-files.t b/t/release/common-files.t
@@ -5,8 +5,6 @@ use warnings;
 use lib 't/lib';
 use MetaCPAN::TestHelpers;
 
-local $TODO = 'FIXME';
-
 test_release(
     {
         name       => 'Common-Files-1.1',