Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation handler crash with AE2 rv2-beta21 #978

Closed
RobertCochran opened this issue Mar 28, 2015 · 14 comments
Closed

Documentation handler crash with AE2 rv2-beta21 #978

RobertCochran opened this issue Mar 28, 2015 · 14 comments

Comments

@RobertCochran
Copy link
Contributor

I had to update AE2 because the new Mekanism was preventing crafting. Apparently, an API or two has
changed between beta 8 (what I had), and beta 21, because now the handler is deciding not to play nice. Here's a crash report - http://pastebin.com/2r5cbh0E

@ultrasn0w
Copy link

I can con confirm this, happens when I press "U" to view the usage of Items in NEI.
Report:
http://pastebin.com/YQVR5HFM

Greetings
ultrasn0w

@RobertCochran
Copy link
Contributor Author

From http://ae-mod.info/Downloads/ - "For developer: Deprecates the old usage of the AEItemDefinitions via the direct method access of * blocks() * parts() * items() * materials() and thus use the new re-direct via definitions(). All definitions are now initialized, no matter what. But SubItems, Items and Blocks are not registered, if by chance are disabled. - thatsIch"

@fnuecke
Copy link
Member

fnuecke commented Mar 29, 2015

Thanks for the info!

I'm temporarily disabling AE2 integration if version rv2-beta-20 or newer is detected for now, since, while deprecated, the used API methods shouldn't crash IMHO. So I don't want to spend a ton of time of working around that if there's a chance for it to get fixed on AE2's end.

I will look into making version specific calls once the AE2 builds have stabilized (latest builds crash for me when opening a terminal, so I can't really test).

@fnuecke
Copy link
Member

fnuecke commented Mar 30, 2015

Seems to be fixed in rv2-beta-22, at least I can't reproduce it there. So I enabled integration for newer versions again.

@fnuecke fnuecke closed this as completed Mar 30, 2015
@ultrasn0w
Copy link

After I grabbed the latest OC build from jenkins (1.5.4.490) and the latest AE version (rv2-beta-22), I still experience the crash whenever i look up the usage of an Item :(

@fnuecke
Copy link
Member

fnuecke commented Mar 30, 2015

Ahh, darn, I think didn't test with controllers disabled...

@fnuecke fnuecke reopened this Mar 30, 2015
@KJA1582
Copy link
Contributor

KJA1582 commented Mar 31, 2015

Got this in a dev setup (latest OC src and dev jar of AE2) and integration for AE2 doesn't get executed (potentially because mod.getMod.isAvaialable returns false).

@fnuecke
Copy link
Member

fnuecke commented Mar 31, 2015

Very latest? Works fine for me in dev with 18 and - so long as I'm careful not to crash it - 22 (i.e. getItemsInNetwork works for me, getCraftables I can't test).

Sorry, something went wrong.

@KJA1582
Copy link
Contributor

KJA1582 commented Mar 31, 2015

1.7.10, but I probably just set it up wrong somehow. Whenever I use IntelliJ's "Minecraft Client" task, it just loads Forge and OC, none of the others. I just put the dev jar of AE2 into the run/mods folder.

Sorry, something went wrong.

@KJA1582
Copy link
Contributor

KJA1582 commented Mar 31, 2015

It just doesn't initialize the integration when the condign option ignorePower is true. Otherwise it does (at least it initializes) work.

Sorry, something went wrong.

@fnuecke
Copy link
Member

fnuecke commented Mar 31, 2015

Ahh, that's a very good point actually, and a sneaky little bug. Using a non-power-related mod availability check now. Thanks for making me aware of that!

Sorry, something went wrong.

@KJA1582
Copy link
Contributor

KJA1582 commented Mar 31, 2015

Your welcome. I simply set the providesPowerower option in ae2 (Mods.scala) to false and it works so far.

@KJA1582
Copy link
Contributor

KJA1582 commented Mar 31, 2015

BTW, how do I 'publish' things in Intellij so I can stick 'em in a non-dev MC install?

@fnuecke
Copy link
Member

fnuecke commented Mar 31, 2015

Run gradlew build, then the JAR is in the /build/libs directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants