Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: b69249376650
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 04d6fc2c3fee
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Jul 14, 2014

  1. cluster: allow multiple calls to setupMaster() 

    Only attributes of 'cluster.settings' will be modified after the first
call, leaving all other cluster initialization alone. Each call that
includes a 'settings' argument triggers a 'setup' event to be emitted.

Instead of each call resetting all values to their defaults, use the
current settings (if any) as the default. This retains setupMaster's
support how cluster.fork() uses setupMaster() to ensure
cluster.settings has been populated.

Update example in docs to use current node coding style and include
an example of progressive configuration.

Signed-off-by: Fedor Indutny <fedor@indutny.com>
    @rmg @indutny
    rmg authored and indutny committed Jul 14, 2014
    Copy the full SHA
    b96e38a View commit details
    Browse the repository at this point in the history

  2. cluster: include settings object in 'setup' event 

    Emits on every call to cluster.setupMaster(), even if no new settings
are given. This is because calling cluster.setupMaster() without
arguments (or with an empty options object) results in the settings
being restored to their defaults.

Signed-off-by: Fedor Indutny <fedor@indutny.com>
    @rmg @indutny
    rmg authored and indutny committed Jul 14, 2014
    Copy the full SHA
    04d6fc2 View commit details
    Browse the repository at this point in the history