Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 8cfbeed27ab9
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: b636ba8186d1
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jan 4, 2015

  1. net: make connect() input validation synchronous 

    Socket.prototype.connect() sometimes throws on bad inputs
after an asynchronous operation. This commit makes the input
validation synchronous. This commit also removes some hard
coded IP addresses.

PR-URL: #8180
Fixes: #8140
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    @cjihrig
    cjihrig committed Jan 4, 2015
    Copy the full SHA
    b636ba8 View commit details
    Browse the repository at this point in the history