Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8097548d56d7
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: be46c47c808a
Choose a head ref
  • 2 commits
  • 12 files changed
  • 1 contributor

Commits on Oct 30, 2013

  1. Copy the full SHA
    3b8b3af View commit details
  2. Copy the full SHA
    be46c47 View commit details
16 changes: 0 additions & 16 deletions spec/corelib/string/end_with_spec.rb

This file was deleted.

6 changes: 0 additions & 6 deletions spec/corelib/string/include_spec.rb

This file was deleted.

404 changes: 0 additions & 404 deletions spec/corelib/string/index_spec.rb

This file was deleted.

9 changes: 0 additions & 9 deletions spec/corelib/string/intern_spec.rb

This file was deleted.

7 changes: 0 additions & 7 deletions spec/corelib/string/reverse_spec.rb

This file was deleted.

12 changes: 0 additions & 12 deletions spec/corelib/string/start_with_spec.rb

This file was deleted.

9 changes: 0 additions & 9 deletions spec/corelib/string/to_a_spec.rb

This file was deleted.

9 changes: 0 additions & 9 deletions spec/corelib/string/to_sym_spec.rb

This file was deleted.

16 changes: 16 additions & 0 deletions spec/filters/bugs/string.rb
Original file line number Diff line number Diff line change
@@ -7,4 +7,20 @@
fails "String#upcase is locale insensitive (only replaces a-z)"
fails "String#size returns the length of self"
fails "String#length returns the length of self"

fails "String#index with Regexp converts start_offset to an integer via to_int"
fails "String#index with Regexp supports \\G which matches at the given start offset"
fails "String#index with Regexp starts the search at the given offset"
fails "String#index with Regexp returns the index of the first match of regexp"
fails "String#index calls #to_int to convert the second argument"
fails "String#index calls #to_str to convert the first argument"
fails "String#index raises a TypeError if passed a Symbol"

fails "String#intern special cases +(binary) and -(binary)"
fails "String#to_sym special cases +(binary) and -(binary)"

fails "String#start_with? ignores arguments not convertible to string"
fails "String#start_with? converts its argument using :to_str"
fails "String#end_with? converts its argument using :to_str"
fails "String#end_with? returns true if other is empty"
end
3 changes: 3 additions & 0 deletions spec/filters/unsupported/mutable_strings.rb
Original file line number Diff line number Diff line change
@@ -5,4 +5,7 @@
fails "String#swapcase! modifies self in place"
fails "String#swapcase! returns nil if no modifications were made"
fails "String#swapcase! raises a RuntimeError when self is frozen"
fails "String#reverse! raises a RuntimeError on a frozen instance that would not be modified"
fails "String#reverse! raises a RuntimeError on a frozen instance that is modified"
fails "String#reverse! reverses self in place and always returns self"
end
1 change: 1 addition & 0 deletions spec/filters/unsupported/tainted.rb
Original file line number Diff line number Diff line change
@@ -46,6 +46,7 @@
fails "String#to_s taints the result when self is tainted"
fails "String#to_str taints the result when self is tainted"
fails "String#swapcase taints resulting string when self is tainted"
fails "String#reverse taints the result if self is tainted"

fails "Pathname.new is tainted if path is tainted"
end
7 changes: 7 additions & 0 deletions spec/rubyspecs
Original file line number Diff line number Diff line change
@@ -225,11 +225,18 @@ core/range/begin_spec
core/range/end_spec

core/string/empty_spec
core/string/end_with_spec
core/string/include_spec
core/string/index_spec
core/string/intern_spec
core/string/length_spec
core/string/size_spec
core/string/reverse_spec
core/string/start_with_spec
core/string/swapcase_spec
core/string/to_a_spec
core/string/to_str_spec
core/string/to_sym_spec
core/string/to_s_spec
core/string/upcase_spec