Fix invalid access denied error caused by access_has_bug_level()

dregad · dregad · commit 8ff13c0d3746 · 2013-02-27T11:50:22.000+01:00
Commit d42e80c changed the code in access_has_bug_level() function, and introduced a bug as the final call to access_compare_level() inverted the 2 parameters which caused an incorrect return value to be returned in certain cases, incorrectly denying access to issues. Issue #15538
diff --git a/core/access_api.php b/core/access_api.php
@@ -435,7 +435,6 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {
 				$s_thresholds[$t_project_id] = $t_report_bug_threshold[0];
 			}
 		}
-
 		if( !access_compare_level( $s_thresholds[$t_project_id], $t_access_level ) ) {
 			return false;
 		}
@@ -449,7 +448,7 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {
 			&& access_compare_level( $t_access_level, $p_access_level );
 	}
 
-	return access_compare_level( $p_access_level, $t_access_level );
+	return access_compare_level( $t_access_level, $p_access_level );
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,6 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {`
`435`	`435`	`$s_thresholds[$t_project_id] = $t_report_bug_threshold[0];`
`436`	`436`	`}`
`437`	`437`	`}`
`438`		`-`
`439`	`438`	`if( !access_compare_level( $s_thresholds[$t_project_id], $t_access_level ) ) {`
`440`	`439`	`return false;`
`441`	`440`	`}`
`@@ -449,7 +448,7 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {`
`449`	`448`	`&& access_compare_level( $t_access_level, $p_access_level );`
`450`	`449`	`}`
`451`	`450`
`452`		`- return access_compare_level( $p_access_level, $t_access_level );`
	`451`	`+ return access_compare_level( $t_access_level, $p_access_level );`
`453`	`452`	`}`
`454`	`453`
`455`	`454`	`/**`