Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 795cb013be12
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7ba96abdcd1a
Choose a head ref
  • 6 commits
  • 5 files changed
  • 1 contributor

Commits on Oct 29, 2013

  1. Copy the full SHA
    2ff1087 View commit details
  2. Copy the full SHA
    17ae28a View commit details
  3. Copy the full SHA
    35bce06 View commit details
  4. Run Array#indices specs

    adambeynon committed Oct 29, 2013
    Copy the full SHA
    dac7a66 View commit details
  5. Run Array#indices specs

    adambeynon committed Oct 29, 2013
    Copy the full SHA
    30f682e View commit details
  6. Copy the full SHA
    7ba96ab View commit details
Showing with 12 additions and 3 deletions.
  1. +6 −3 spec/filters/bugs/array.rb
  2. +1 −0 spec/filters/unsupported/array_subclasses.rb
  3. +1 −0 spec/filters/unsupported/frozen.rb
  4. +1 −0 spec/filters/unsupported/private_methods.rb
  5. +3 −0 spec/rubyspecs
9 changes: 6 additions & 3 deletions spec/filters/bugs/array.rb
Original file line number Diff line number Diff line change
@@ -116,8 +116,6 @@
fails "Array#& tries to convert the passed argument to an Array using #to_ary"
fails "Array#& determines equivalence between elements in the sense of eql?"

fails "Array#index returns the index of the first element == to object"

fails "Array#join calls #to_str to convert the separator to a String"
fails "Array#join does not call #to_str on the separator if the array is empty"
fails "Array#join raises a TypeError if the separator cannot be coerced to a String by calling #to_str"
@@ -158,7 +156,6 @@
fails "Array#replace tries to convert the passed argument to an Array using #to_ary"

fails "Array#rindex rechecks the array size during iteration"
fails "Array#rindex returns the first index backwards from the end where element == to object"

fails "Array#select returns a new array of elements for which block is true"

@@ -227,4 +224,10 @@
fails "Array#hash returns the same hash for equal recursive arrays through hashes"
fails "Array#hash returns the same hash for equal recursive arrays"
fails "Array#hash returns the same fixnum for arrays with the same content"

fails "Array#initialize_copy tries to convert the passed argument to an Array using #to_ary"
fails "Array#initialize_copy does not make self dependent to the original array"
fails "Array#initialize_copy returns self"
fails "Array#initialize_copy properly handles recursive arrays"
fails "Array#initialize_copy replaces the elements with elements from other array"
end
1 change: 1 addition & 0 deletions spec/filters/unsupported/array_subclasses.rb
Original file line number Diff line number Diff line change
@@ -32,4 +32,5 @@
fails "Array#[] with a subclass of Array returns a subclass instance with [-n..-m]"
fails "Array#[] with a subclass of Array returns a subclass instance with [-n...-m]"
fails "Array.[] with a subclass of Array returns an instance of the subclass"
fails "Array#initialize_copy does not call #to_ary on Array subclasses"
end
1 change: 1 addition & 0 deletions spec/filters/unsupported/frozen.rb
Original file line number Diff line number Diff line change
@@ -57,6 +57,7 @@
fails "Array#keep_if on frozen objects with falsy block keeps elements after any exception"
fails "Array#keep_if on frozen objects with falsy block raises a RuntimeError"
fails "Array#initialize raises a RuntimeError on frozen arrays"
fails "Array#initialize_copy raises a RuntimeError on a frozen array"

fails "Hash#clear raises a RuntimeError if called on a frozen instance"
fails "Hash#initialize_copy raises a RuntimeError if called on a frozen instance that would not be modified"
1 change: 1 addition & 0 deletions spec/filters/unsupported/private_methods.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
opal_filter "Private methods" do
fails "Array#initialize is private"
fails "The defined? keyword when called with a method name having a module as a receiver returns nil if the method is private"
fails "Array#initialize_copy is private"

fails "Hash#initialize_copy is private"
fails "Hash#initialize is private"
3 changes: 3 additions & 0 deletions spec/rubyspecs
Original file line number Diff line number Diff line change
@@ -36,6 +36,9 @@ core/array/frozen_spec
core/array/hash_spec
core/array/include_spec
core/array/index_spec
core/array/indexes_spec
core/array/indices_spec
core/array/initialize_copy_spec
core/array/initialize_spec
core/array/insert_spec
core/array/inspect_spec