Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols need to support UTF-8 names #2172

Closed
cheald opened this issue Nov 11, 2014 · 2 comments
Closed

Symbols need to support UTF-8 names #2172

cheald opened this issue Nov 11, 2014 · 2 comments
Labels
encoding jit parser
Milestone
JRuby 1.7.18

Comments

@cheald
Copy link
Contributor

cheald commented Nov 11, 2014

MRI currently supports UTF-8 symbols:

x = :"\u{3042}" # => :あ

However, JRuby always treats symbols as US-ASCII, resulting in things like encoding errors when trying to inspect one:

> x = :"\u{3042}"
ArgumentError: invalid byte sequence in US-ASCII
from org/jruby/RubySymbol.java:221:in `inspect'

This is a source of a number of errors in the new stdlib test suite.
@enebo
Copy link
Member

enebo commented Nov 11, 2014

For some reason I think we have an issue for this but I don't see it offhand :)

@enebo enebo added the parser label Nov 11, 2014
@enebo enebo added this to the JRuby 1.7.18 milestone Nov 11, 2014
enebo added a commit that referenced this issue Dec 10, 2014
@enebo
Fixes #2172 on 1.9 and only for interpreted mode
d5b70fd
headius added a commit that referenced this issue Dec 10, 2014
@headius
JIT changes for Symbol encoding issue #2172.
2d62cd2
@enebo
Copy link
Member

enebo commented Dec 10, 2014

This is fixed on 1.7 now but we also need equivalent changes on master. We might try and more elegantly do this on master. Leaving open for now.

enebo added a commit that referenced this issue Dec 10, 2014
@enebo
tests now passing from #2172 getting fixed
ff3d32c
@enebo enebo closed this as completed in 89f548e Dec 11, 2014
This was referenced Dec 18, 2014
Closed
Closed
@headius headius mentioned this issue Nov 14, 2016
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encoding jit parser
Projects
None yet
Milestone
JRuby 1.7.18
Development

No branches or pull requests
2 participants
@cheald @enebo