Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: e526350
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: e28fa43
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on May 6, 2012

  1. Add filter in Manage Users page to show/hide disabled users 

    Original patch written by David Newcomb.

Fixed issue with new filter not specified on the multi-page navigation
links. Also made minor cosmetic changes: whitespace, coding guidelines.

Fixes #11726
    @dregad
    dregad committed May 6, 2012
    Copy the full SHA
    a21374a View commit details
    Browse the repository at this point in the history

  2. Code cleanup in Manage User page 

    Simplify code by using a for loop to print the column headers instead of
manually building the table cells one by one. Note that this actually
changes the label of the 'Protected' column from the padlock icon to a
text description.

Rename 'hide' variable to 'hide_inactive'. With the addition of the new
filter option 'show_disabled', using just 'hide' was potentially
confusing.
    @dregad
    dregad committed May 6, 2012
    Copy the full SHA
    129a8e5 View commit details
    Browse the repository at this point in the history

  3. The filter in managed_user_page.php is not persistent 

    The filter values stored in the cookie whenever the criteria change,
were restored to the form variables instead of the sanitized ($c_)
variables, and were therefore not taken into account when building the
page.

Fixes #14216
    @dregad
    dregad committed May 6, 2012
    Copy the full SHA
    e28fa43 View commit details
    Browse the repository at this point in the history