better deprecation code

mojolicious · Sep 9, 2013 · aa77727 · aa77727
1 parent 9274340
commit aa77727
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/Mojo/Base.pm b/lib/Mojo/Base.pm
@@ -47,9 +47,6 @@ sub new {
   bless @_ ? @_ > 1 ? {@_} : {%{$_[0]}} : {}, ref $class || $class;
 }
 
-# Performance is very important for something as often used as accessors,
-# so we optimize them by compiling our own code, don't be scared, we have
-# tests for every single case
 sub attr {
   my ($class, $attrs, $default) = @_;
   return unless ($class = ref $class || $class) && $attrs;

diff --git a/lib/Mojolicious.pm b/lib/Mojolicious.pm
@@ -4,7 +4,7 @@ use Mojo::Base 'Mojo';
 # "Fry: Shut up and take my money!"
 use Carp 'croak';
 use Mojo::Exception;
-use Mojo::Util 'decamelize';
+use Mojo::Util qw(decamelize deprecated);
 use Mojolicious::Commands;
 use Mojolicious::Controller;
 use Mojolicious::Plugins;
@@ -90,7 +90,7 @@ sub new {
 
   # DEPRECATED in Top Hat!
   if (my $sub = $self->can("${mode}_mode")) {
-    warn qq{"sub ${mode}_mode {...}" in application class is DEPRECATED.\n};
+    deprecated qq{"sub ${mode}_mode {...}" in application class is DEPRECATED};
     $self->$sub(@_);
   }