[Truffle] - String#downcase! returning nil if no changes were made.

jruby · Dec 22, 2014 · 827f20a · 827f20a
1 parent 2851935
commit 827f20a
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/core/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java b/core/src/main/java/org/jruby/truffle/nodes/core/StringNodes.java
@@ -457,11 +457,18 @@ public DowncaseBangNode(DowncaseBangNode prev) {
         }
 
         @Specialization
-        public RubyString downcase(RubyString string) {
+        public RubyBasicObject downcase(RubyString string) {
             notDesignedForCompilation();
 
-            string.set(ByteList.create(string.toString().toLowerCase()));
-            return string;
+            ByteList newByteList = ByteList.create(string.toString().toLowerCase());
+            newByteList.setEncoding(string.getBytes().getEncoding());
+
+            if (newByteList.equals(string.getBytes())) {
+                return getContext().getCoreLibrary().getNilObject();
+            } else {
+                string.set(newByteList);
+                return string;
+            }
         }
     }