Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: d979cf6a6d71
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: 791fbd93d09b
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 4, 2012

  1. Custom fields api - optimize and use db_query_bound 

    Replaces all uses of db_query() by db_query_bound() in the API.

Some SQL queries were rewritten in a cleaner and more efficient way.

custom_field_update() was greatly simplified by use of a foreach loop
instead of nearly identical code blocks for processing of each field to
update.

Fixes #14765, #14766
    @dregad
    dregad committed Oct 4, 2012
    Copy the full SHA
    6e53cd2 View commit details
    Browse the repository at this point in the history

  2. Don't display custom fields from disabled projects in view issues page 

    SQL for ALL_PROJECTS in custom_field_get_linked_ids() function was
modified to filter out disabled projects.

Thanks to vibe972 who originally submitted a patch for this on Github.
Original commit was rewritten due to changes made to the API.

Fixes #14764
    @dregad
    dregad committed Oct 4, 2012
    Copy the full SHA
    24f3971 View commit details
    Browse the repository at this point in the history

  3. Improve custom fields error messages 

    Introduce an additional 'Invalid Custom Field property' error message
that includes the name(s) of the properties which failed validation when
attempting to update the custom field.

Note: skip error message number 1305 to maintain forward-compatibility
with constants as they are defined in master branch

Fixes #14767
    @dregad
    dregad committed Oct 4, 2012
    Copy the full SHA
    d8d3409 View commit details
    Browse the repository at this point in the history

  4. Use object properties instead of bug_get_field() calls

    @dregad
    dregad committed Oct 4, 2012
    Copy the full SHA
    791fbd9 View commit details
    Browse the repository at this point in the history