Fix Hash#inspect by not caching map and smap

elia · elia · commit c369385aead2 · 2014-11-21T23:59:11.000+01:00
Apparently as #650 demonstrates `smap` gets corrupted and ends up being different from `self.smap`, actually seems to be equal to value (or `value.smap`). My gut tells me that we’re missing a `var smap` somewhere. The fix just always fetches map and smap from self. Closes #650.
diff --git a/opal/corelib/hash.rb b/opal/corelib/hash.rb
@@ -569,11 +569,12 @@ def inspect
     %x{
       var top = (inspect_ids === null);
       try {
-        var inspect = [],
+
+        var key, value,
+            inspect = [],
             keys = self.keys
-            _map = self.map,
-            smap = self.smap,
-            id = #{object_id};
+            id = self.$object_id(),
+            counter = 0;
 
         if (top) {
           inspect_ids = {}
@@ -586,12 +587,11 @@ def inspect
         inspect_ids[id] = true;
 
         for (var i = 0, length = keys.length; i < length; i++) {
-          var key = keys[i],
-              value = key.$$is_string ? smap[key] : _map[key.$hash()];
-
-          value = value;
-          key = key;
-          inspect.push(key.$inspect() + '=>' + value.$inspect());
+          key   = keys[i];
+          value = key.$$is_string ? self.smap[key] : self.map[key.$hash()];
+          key   = key.$inspect();
+          value = value.$inspect();
+          inspect.push(key + '=>' + value);
         }
 
         return '{' + inspect.join(', ') + '}';
