fixed cloning bug in Mojo::Headers

mojolicious · Mar 13, 2013 · 49fddaf · 49fddaf
1 parent f57a325
commit 49fddaf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -8,6 +8,7 @@
   - Fixed bug in Mojo::Headers that prevented multiline headers from being
     parsed correctly.
   - Fixed multiline header support in hash representation of Mojo::Headers.
+  - Fixed cloning bug in Mojo::Headers.
 
 3.89  2013-03-04
   - Improved documentation.

diff --git a/lib/Mojo/Headers.pm b/lib/Mojo/Headers.pm
@@ -39,11 +39,8 @@ sub add {
 }
 
 sub clone {
-  my $self  = shift;
-  my $clone = $self->new;
-  $clone->{headers}{$_} = [@{$self->{headers}{$_}}]
-    for keys %{$self->{headers}};
-  return $clone;
+  my $self = shift;
+  return $self->new->from_hash($self->to_hash(1));
 }
 
 sub from_hash {

diff --git a/t/mojo/headers.t b/t/mojo/headers.t
@@ -110,6 +110,8 @@ $clone = $headers->clone;
 $clone->expect('nothing');
 is $headers->expect, '100-continue', 'right value';
 is $clone->expect,   'nothing',      'right value';
+$clone = Mojo::Headers->new->add(Foo => [qw(bar baz)])->clone;
+is_deeply $clone->to_hash(1)->{Foo}, [[qw(bar baz)]], 'right structure';
 
 # Multiline values
 $headers = Mojo::Headers->new;