Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test, and Cookbook example, of array-ref arg #39

Merged
merged 2 commits into from May 4, 2019
Merged

Conversation

mohawk2
Copy link
Collaborator

@mohawk2 mohawk2 commented Mar 22, 2015

Gives budding Inline users code they can cut+paste for instant working code.

@zmughal
Copy link

zmughal commented Mar 22, 2015

👍 Nice!

@sisyphus
Copy link
Collaborator

From: mohawk2
Sent: Sunday, March 22, 2015 2:50 PM
To: ingydotnet/inline-c-pm
Subject: [inline-c-pm] Add test, and Cookbook example, of array-ref arg
(#39)

Ed,

Gives budding Inline users code they can cut+paste for instant working
code.

Why the call to "SvGETMAGIC(array);" ?
The test script seems to work just as well without it.

Also, on perl-5.16 (and presumably earlier), the build fails with:

_29refargs_t_f0c98d.o:_29_t_f0c98d.c:(.text+0x34): undefined reference to
`_av_top_index'

We can remedy this with (eg):

#ifndef av_top_index
#define av_top_index AvFILL
#endif

Cheers,
Rob

@mohawk2
Copy link
Collaborator Author

mohawk2 commented Sep 22, 2018

@sisyphus I zapped the SvGETMAGIC stuff since as you said, it was unnecessary. There now isn't any reference to av_top_index so I haven't added the #define you mention.

@ingydotnet Feel like merging this? I rebased it against current master.

@mohawk2
Copy link
Collaborator Author

mohawk2 commented Apr 2, 2019

@perlpunk Time for merge maybe?

@perlpunk perlpunk merged commit fc7cc5b into master May 4, 2019
@perlpunk
Copy link
Collaborator

perlpunk commented May 4, 2019

Thanks, merged!

@mohawk2 mohawk2 deleted the cookbook-refs branch May 4, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants