Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 7e9d2f8de819
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: ecdf151bd735
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 23, 2015

  1. test: Environment varible to specify directory for pipes

    At the uv layer pipes are connected with uv_pipe_connect.
    The current spec for this method indicates that the maximum
    length is limited to the size of length of
    sizeof(sockaddr_un.sun_path), typically between 92 and
    108 bytes. Anything longer than that just gets truncated.
    
    The simple testsuite currently creates pipes in directories
    under the directory where node was built.  In our jenkins
    jobs this sometimes ends up being a deep enough path that
    the path for the pipes is getting truncated.  The result
    is that tests using pipes fail with errors that don't
    make it obvious what the problem is.
    
    Even if the errors were helpful, we still need a way
    to avoid the truncation.
    
    This patch adds the environment variable NODE_PIPE_DIR.
    If set the tests create pipes in this directory instead of
    the current defaults.  In addition the test harness is
    updated to remove/delete this directory before/after
    each test is run.
    
    	modified:   test/common.js
    	modified:   test/simple/test-net-pipe-connect-errors.js
    	modified:   test/testpy/__init__.py
    	modified:   test/simple/test-cluster-eaccess.js
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #9381
    mhdawson committed Mar 23, 2015
    Copy the full SHA
    67c0dbe View commit details
    Browse the repository at this point in the history
  2. test: Environment varible to specify directory for pipes

    Updated to address initial set of comments
    
    	modified:   test/common.js
    	modified:   test/simple/test-cluster-eaccess.js
    	modified:   test/simple/test-net-pipe-connect-errors.js
    	modified:   test/testpy/__init__.py
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #9381
    mhdawson committed Mar 23, 2015
    Copy the full SHA
    4d3ef75 View commit details
    Browse the repository at this point in the history
  3. test: Environment varible to specify directory for pipes

    Updated to address second set of comments
    
    	modified:   test/simple/test-net-pipe-connect-errors.js
    	modified:   test/testpy/__init__.py
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #9381
    mhdawson committed Mar 23, 2015
    Copy the full SHA
    ecdf151 View commit details
    Browse the repository at this point in the history