Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to standard Changes format #78

Merged
merged 9 commits into from Jun 3, 2015
Merged

Move to standard Changes format #78

merged 9 commits into from Jun 3, 2015

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Mar 15, 2015

This is to address #67.

This allows for the Changes file to be parsed on MetaCPAN by https://metacpan.org/pod/CPAN::Changes.

@mohawk2
Copy link
Member

mohawk2 commented Mar 15, 2015

Fantastic work!


my @releases = map { +{ $_->version => $_->date } } $changes->releases;

note Dumper \@releases;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this were diag instead of note it would show up in the Travis log?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should still show up since I'm using -v, but turns out, it isn't running at all?

/me investigates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wager test-files might be confusing us. To the docs, Robin!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need AUTHOR_TESTING set to true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should default to true, but I'll make it explicit.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 49.03% when pulling e75f22d on changesfix into fc32b6b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.01% when pulling f169ff1 on changesfix into fc32b6b on master.

@mohawk2
Copy link
Member

mohawk2 commented Mar 16, 2015

Reviewed: looks great!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.42% when pulling a86c345 on changesfix into beebefb on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.4% when pulling 7dcc8e1 on changesfix into 5148b8b on master.

@zmughal zmughal force-pushed the changesfix branch 3 times, most recently from c6badff to 6689697 Compare May 3, 2015 20:05
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.4% when pulling 6689697 on changesfix into 973baea on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.4% when pulling 6689697 on changesfix into 973baea on master.

mohawk2 and others added 7 commits June 3, 2015 13:57
This will allow us to take advantage of the standard format used by
MetaCPAN and package distributions.
…ate]]"

This was done by running those lines through the filter

    grep -o '[[:digit:]_.]\+' \
      | xargs -I{} echo v{}   \
      | xargs -I{} git log -1 --pretty="format:{} %ai" {}

which uses the author date recorded for the respective PDL version tag.
This is to address <#67>.

This allows for the Changes file to be parsed on MetaCPAN by
<https://metacpan.org/pod/CPAN::Changes>.
@zmughal zmughal modified the milestones: PDL v2.011, PDL v2.009 Jun 3, 2015
@zmughal
Copy link
Member Author

zmughal commented Jun 3, 2015

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.44% when pulling a96c184 on changesfix into b55b188 on master.

@mohawk2 mohawk2 merged commit a96c184 into master Jun 3, 2015
@zmughal zmughal mentioned this pull request Jun 14, 2015
@zmughal zmughal modified the milestones: PDL v2.012, PDL v2.012_01 Jul 29, 2015
@zmughal zmughal deleted the changesfix branch August 5, 2015 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants