Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: e818cbfa4ba1
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 177aa42a538e
Choose a head ref
  • 6 commits
  • 113 files changed
  • 5 contributors

Commits on Mar 17, 2015

  1. Copy the full SHA
    a91bef9 View commit details
    Browse the repository at this point in the history
  2. build: fix use of strict aliasing

    The -fno-strict-aliasing flag was added to fix compilation warnings when
    building Node.js with GCC <= 4.4
    trevnorris committed Mar 17, 2015
    Copy the full SHA
    8d53bec View commit details
    Browse the repository at this point in the history
  3. lib: fix stdio/ipc sync i/o regression

    process.send() should be synchronous, it should block until the message
    has been sent in full, but it wasn't after the second-to-last libuv
    upgrade because of commit libuv/libuv@393c1c5 ("unix: set non-block
    mode in uv_{pipe,tcp,udp}_open"), which made its way into io.js in
    commit 07bd05b ("deps: update libuv to 1.2.1").
    
    Commit libuv/libuv@b36d4ff ("unix: implement uv_stream_set_blocking()")
    as landed in io.js in commit 9681fca ("deps: update libuv to 1.4.0")
    makes it possible to restore the synchronous behavior again and that's
    precisely what this commit does.
    
    The same line of reasoning applies to `net.Socket({ fd: 1 })`: creating
    a socket object from a stdio file descriptor, like the `process.stdout`
    getter does, should put the file descriptor in blocking mode for
    compatibility reasons.
    
    PR-URL: nodejs/node#774
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis authored and trevnorris committed Mar 17, 2015
    Copy the full SHA
    201a706 View commit details
    Browse the repository at this point in the history
  4. uv: float win pipe patch

    Float patch to fix pipe on Windows. Original commit message:
    
      win: fix pipe blocking writes
    
      In the code path for pipe blocking writes, WriteFile is already
      posting a completion packet to the I/O completion port.
      POST_COMPLETION_FOR_REQ was causing the same request to get
      returned twice by GetCompletionStatusEx.
      Also on the same code path, we were waiting on the wrong event.
    
      We need to update queued_bytes and write_queue_size when a
      blocking write request completes asynchronously.
    
    Ref: libuv/libuv#238
    orangemocha authored and trevnorris committed Mar 17, 2015
    Copy the full SHA
    6403576 View commit details
    Browse the repository at this point in the history
  5. uv: fix setsockopt for multicast options

    Float patch to fix setsockopt for multicast on Solaris and derivatives.
    Original commit message:
    
      solaris: fix setsockopt for multicast options
    
      On Solaris and derivatives such as SmartOS, the length of socket options
      for multicast and ttl options is not always sizeof(char).
    
      This fixes the udp_options and udp_options6 tests.
    
    Ref: libuv/libuv#243
    Julien Gilli authored and trevnorris committed Mar 17, 2015
    Copy the full SHA
    cdc929b View commit details
    Browse the repository at this point in the history
  6. uv: fix size calculation in select() fallback

    Original commit message:
    
      darwin: fix size calculation in select() fallback
    
      Apple's `fd_set` stores its bits in an array of 32-bit integers, which
      means `FD_ISSET()` may read out of bounds if we allocate storage at
      byte granularity. There's also a chance that the `select()` call could
      corrupt the heap, although I didn't investigate that.
    
      This issue was discovered by LLVM's AddressSanitizer which caught
      `FD_ISSET()` trying to read out of bounds.
    
    Ref: libuv/libuv#241
    oleavr authored and trevnorris committed Mar 17, 2015
    Copy the full SHA
    177aa42 View commit details
    Browse the repository at this point in the history