Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
test: add test for bad unicode sequences
Browse files Browse the repository at this point in the history
This was a regression in 0.7.9.
  • Loading branch information
dscape authored and bnoordhuis committed Jun 9, 2012
1 parent 65242ab commit 284816e
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions test/simple/test-bad-unicode.js
@@ -0,0 +1,26 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
var assert = require('assert');
var bad_unicode = '\uc/ef';

console.log(bad_unicode);

assert.equal(bad_unicode, "uc/ef");

3 comments on commit 284816e

@piscisaureus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V8 changed parser behavior in 3.11 - so this "regression" is deliberate.

Related v8 changes:
https://chromiumcodereview.appspot.com/9490006/
https://chromiumcodereview.appspot.com/9490006/diff/3003/test/test262/test262.status

@dscape @bnoordhuis Is there any reason we should prefer the old behaviour ?

@piscisaureus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, spoken to @dscape. This test will be changed to match the 3.11 behavior.

@bnoordhuis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we should prefer the old behaviour?

No. If that is what V8 is going to do from now on and it follows browser behavior, we'll stick with it. I've reverted the test in 9dda8e5.

Please sign in to comment.