Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 26315c2bd574
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: e818cbfa4ba1
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Mar 17, 2015

  1. uv: fix setsockopt for multicast options

    Float patch to fix setsockopt for multicast on Solaris and derivatives.
    Original commit message:
    
      solaris: fix setsockopt for multicast options
    
      On Solaris and derivatives such as SmartOS, the length of socket options
      for multicast and ttl options is not always sizeof(char).
    
      This fixes the udp_options and udp_options6 tests.
    
    Ref: libuv/libuv#243
    Julien Gilli authored and trevnorris committed Mar 17, 2015
    Copy the full SHA
    ca282c3 View commit details
    Browse the repository at this point in the history
  2. uv: fix size calculation in select() fallback

    Original commit message:
    
      darwin: fix size calculation in select() fallback
    
      Apple's `fd_set` stores its bits in an array of 32-bit integers, which
      means `FD_ISSET()` may read out of bounds if we allocate storage at
      byte granularity. There's also a chance that the `select()` call could
      corrupt the heap, although I didn't investigate that.
    
      This issue was discovered by LLVM's AddressSanitizer which caught
      `FD_ISSET()` trying to read out of bounds.
    
    Ref: libuv/libuv#241
    oleavr authored and trevnorris committed Mar 17, 2015
    Copy the full SHA
    e818cbf View commit details
    Browse the repository at this point in the history