Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 9b0e3db4f0e6
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: e8a04f39199a
Choose a head ref
  • 18 commits
  • 52 files changed
  • 2 contributors

Commits on Dec 10, 2014

  1. test: mark more tests as flaky 

    Marking these two tests as flaky, since they have been failing
intermittenly in recent builds:
test-debug-signal-cluster
test-cluster-basic
    @orangemocha
    orangemocha committed Dec 10, 2014
    Copy the full SHA
    8708c7a View commit details
    Browse the repository at this point in the history

  2. Add-on init: Dispatch signature on compile time 

    Handle different init() signatures in a generic and type safe way. An adapter is selected at compile-time based on the signature of the init function. The adapter is stored in the module struct. At run-time the adapter unpacks the users init function and provides the requested arguments.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    9a178a1 View commit details
    Browse the repository at this point in the history

  3. Consistency: renamed 'targets' to 'exports' in test add-ons 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    c20cfcf View commit details
    Browse the repository at this point in the history

  4. Add-on init: There, cpplint fixed it. 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    0d9b8b6 View commit details
    Browse the repository at this point in the history

  5. Add-on init: Cleaned up internal module init 

    Passing unused parameters isn't necessary any longer.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    6f21885 View commit details
    Browse the repository at this point in the history

  6. Add-on init: Fixed test add-ons 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    d785560 View commit details
    Browse the repository at this point in the history

  7. Add-on init: Added init signature test cases. 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    db271a0 View commit details
    Browse the repository at this point in the history

  8. Add-on init: relinted 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    078029d View commit details
    Browse the repository at this point in the history

  9. Add-on init: polishing 

    Cosmetics and corner case tests, like the void init function.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    f90428e View commit details
    Browse the repository at this point in the history

  10. Add-on init: Added C++11 variadic variant 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    bae2b0b View commit details
    Browse the repository at this point in the history

  11. Scrutiny: Build an add-on with C++11 enabled 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    f460083 View commit details
    Browse the repository at this point in the history

  12. Add-on init: relinted... again :-/ 

    Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    79de1a4 View commit details
    Browse the repository at this point in the history

  13. Add-on init: Simplified OptionalInitArg 

    Replaced operator() with a plain static member function.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    f10fba7 View commit details
    Browse the repository at this point in the history

  14. Add-on init: Touch-ups 

    Renamed struct field 'init' to 'nm_init'.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    4983f79 View commit details
    Browse the repository at this point in the history

  15. Add-on init: Removed "private" argument 

    The private argument is pretty useless since it is restricted to a compile-time constant. The only place to access this constant private value is the init function. This really makes no sense. Removing.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    01ea8ef View commit details
    Browse the repository at this point in the history

  16. Revert "Add-on init: Removed "private" argument" 

    This reverts commit dff8b1b.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    5bcf0b4 View commit details
    Browse the repository at this point in the history

  17. Add-on init: Refactor after review by @indutny 

    * do not attempt to inline registerAddon
* removed C++11 variant
* diff hygiene: respect line ownership in macros
* cosmetics

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    6d412ab View commit details
    Browse the repository at this point in the history

  18. Add-on init: Fix mess left after rebase 

    Not sure how, but apparently I lost some changes in the rebase yesterday. Also not sure how I didn't notice. Anyway, this should do it.

Reviewed-By: Test Reviewer Name <fake@email.com>
PR-URL: #8828
    @agnat @orangemocha
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    e8a04f3 View commit details
    Browse the repository at this point in the history