Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 349f57ba8ec5
Choose a base ref
...
head repository: jruby/jruby
compare: 0c9ebf67f6b0
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 20, 2015

  1. Proper way to check a byte for mbc.

    @headius
    headius committed Mar 20, 2015
    Configuration menu
    Copy the full SHA
    4a6ed4b View commit details
    Browse the repository at this point in the history

  2. Tidy up semantics of matchdata out param in search/match. 

    Previously the semantics were a bit of a mix; some consumers
passed the out param *and* wanted the matchdata set into context,
some did not want it set, and some did not pass an out param. The
modified logic always uses *either* context.setBackref *or* the
out param in all cases.

Methods that use regexp match/search and need matchdata set now
skip passing the out param, localizing backref setting for those
methods back to where it should live.

This also fixes matchPos to not require the IRubyObject[] out param
if the caller is not interested in the coerced string.
    @headius
    headius committed Mar 20, 2015
    Configuration menu
    Copy the full SHA
    0c9ebf6 View commit details
    Browse the repository at this point in the history