jruby · Mar 19, 2015 · Mar 19, 2015
Showing with 46 additions and 65 deletions.

+0 −19 spec/truffle/tags/core/array/join_tags.txt

+0 −46 truffle/src/main/java/org/jruby/truffle/nodes/core/ArrayNodes.java

+46 −0 truffle/src/main/ruby/core/rubinius/common/array.rb
diff --git a/spec/truffle/tags/core/array/join_tags.txt b/spec/truffle/tags/core/array/join_tags.txt
@@ -1,20 +1 @@
-fails:Array#join returns a string formed by concatenating each element.to_str separated by separator
-fails:Array#join uses the same separator with nested arrays
-fails:Array#join attempts coercion via #to_str first
-fails:Array#join attempts coercion via #to_ary second
-fails:Array#join attempts coercion via #to_s third
-fails:Array#join raises a NoMethodError if an element does not respond to #to_str, #to_ary, or #to_s
-fails:Array#join taints the result if the Array is tainted and non-empty
-fails:Array#join taints the result if the result of coercing an element is tainted
-fails:Array#join untrusts the result if the Array is untrusted and non-empty
-fails:Array#join untrusts the result if the result of coercing an element is untrusted
-fails:Array#join uses the first encoding when other strings are compatible
 fails:Array#join fails for arrays with incompatibly-encoded strings
-fails:Array#join does not separate elements when the passed separator is nil
-fails:Array#join calls #to_str to convert the separator to a String
-fails:Array#join does not call #to_str on the separator if the array is empty
-fails:Array#join with a tainted separator taints the result if the array has two or more elements
-fails:Array#join with an untrusted separator untrusts the result if the array has two or more elements
-fails:Array#join with $, separates elements with default separator when the passed separator is nil
-fails:Array#join raises an ArgumentError when the Array is recursive
-fails:Array#join uses the widest common encoding when other strings are incompatible
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/ArrayNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/ArrayNodes.java
@@ -1722,52 +1722,6 @@ public Object insert(RubyArray array, int index, int value) {
 
     }
 
-    @CoreMethod(names = "join", optional = 1)
-    public abstract static class JoinNode extends ArrayCoreMethodNode {
-
-        public JoinNode(RubyContext context, SourceSection sourceSection) {
-            super(context, sourceSection);
-        }
-
-        public JoinNode(JoinNode prev) {
-            super(prev);
-        }
-
-        @Specialization
-        public RubyString join(RubyArray array, UndefinedPlaceholder unused) {
-            Object separator = getContext().getCoreLibrary().getGlobalVariablesObject().getInstanceVariable("$,");
-            if (separator == nil()) {
-                separator = getContext().makeString("");
-            }
-
-            if (separator instanceof RubyString) {
-                return join(array, (RubyString) separator);
-            } else {
-                throw new UnsupportedOperationException();
-            }
-        }
-
-        @Specialization
-        public RubyString join(RubyArray array, RubyString separator) {
-            notDesignedForCompilation();
-
-            final StringBuilder builder = new StringBuilder();
-
-            final Object[] objects = array.slowToArray();
-
-            for (int n = 0; n < objects.length; n++) {
-                if (n > 0) {
-                    builder.append(separator);
-                }
-
-                builder.append(objects[n]);
-            }
-
-            return getContext().makeString(builder.toString());
-        }
-
-    }
-
     @CoreMethod(names = {"map", "collect"}, needsBlock = true, returnsEnumeratorIfNoBlock = true)
     @ImportGuards(ArrayGuards.class)
     public abstract static class MapNode extends YieldingCoreMethodNode {

diff --git a/truffle/src/main/ruby/core/rubinius/common/array.rb b/truffle/src/main/ruby/core/rubinius/common/array.rb
@@ -634,6 +634,52 @@ def inspect
 
   alias_method :to_s, :inspect
 
+  def join(sep=nil)
+    return "".force_encoding(Encoding::US_ASCII) if @total == 0
+
+    out = ""
+    raise ArgumentError, "recursive array join" if Thread.detect_recursion self do
+      sep = sep.nil? ? $, : StringValue(sep)
+
+      # We've manually unwound the first loop entry for performance
+      # reasons.
+      x = @tuple[@start]
+
+      if str = String.try_convert(x)
+        x = str
+      elsif ary = Array.try_convert(x)
+        x = ary.join(sep)
+      else
+        x = x.to_s
+      end
+
+      out.force_encoding(x.encoding)
+      out << x
+
+      total = @start + size()
+      i = @start + 1
+
+      while i < total
+        out << sep if sep
+
+        x = @tuple[i]
+
+        if str = String.try_convert(x)
+          x = str
+        elsif ary = Array.try_convert(x)
+          x = ary.join(sep)
+        else
+          x = x.to_s
+        end
+
+        out << x
+        i += 1
+      end
+    end
+
+    Rubinius::Type.infect(out, self)
+  end
+
   def keep_if(&block)
     return to_enum :keep_if unless block_given?