Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: db81738cbd4d
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 57d168ba21e6
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 15, 2015

  1. [Truffle] Untagged passing Object#instance_exec specs.

    @nirvdrum
    nirvdrum committed Mar 15, 2015
    Copy the full SHA
    cbbf93f View commit details

  2. [Truffle] We have some failure cases, so mark not designed for compil… 

    …ation.
    @nirvdrum
    nirvdrum committed Mar 15, 2015
    Copy the full SHA
    57d168b View commit details
Showing with 2 additions and 7 deletions.
  1. +0 −7 spec/truffle/tags/core/object/instance_exec_tags.txt
  2. +2 −0 truffle/src/main/java/org/jruby/truffle/nodes/core/BasicObjectNodes.java
7 changes: 0 additions & 7 deletions spec/truffle/tags/core/object/instance_exec_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
fails:Object#instance_exec raises a LocalJumpError unless given a block
fails:Object#instance_exec passes any arguments to the block
fails:Object#instance_exec only binds the exec to the receiver
fails:Object#instance_exec binds self to the receiver
fails:Object#instance_exec binds the block's binding self to the receiver
fails:Object#instance_exec executes in the context of the receiver
fails:Object#instance_exec has access to receiver's instance variables
fails:Object#instance_exec invokes Method objects without rebinding self
fails:Object#instance_exec sets class variables in the receiver
fails:Object#instance_exec raises a TypeError when defining methods on an immediate
fails:Object#instance_exec raises a TypeError when defining methods on numerics
2 changes: 2 additions & 0 deletions truffle/src/main/java/org/jruby/truffle/nodes/core/BasicObjectNodes.java
View file
Original file line number Diff line number Diff line change
@@ -234,6 +234,8 @@ public InstanceExecNode(InstanceExecNode prev) {

@Specialization
public Object instanceExec(VirtualFrame frame, Object receiver, Object[] arguments, RubyProc block) {
notDesignedForCompilation();

return yieldWithModifiedSelf(frame, block, receiver, arguments);
}