Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b8fd3d4907b5
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2fc6f5a7edf5
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 23, 2014

  1. def and define_method return the method name.

    This is a Ruby 2.1 change, but as we previously returned nil, this
    is unlikely to be a compatibility issue.
    mieko committed Mar 23, 2014

    Verified

    This commit was signed with the committer’s verified signature.
    tadeokondrak Tadeo Kondrak
    Copy the full SHA
    91e9d8a View commit details

Commits on Mar 26, 2014

  1. Merge pull request #519 from mieko/def_symbol

    def and define_method return the method name.
    meh committed Mar 26, 2014

    Verified

    This commit was signed with the committer’s verified signature.
    tadeokondrak Tadeo Kondrak
    Copy the full SHA
    2fc6f5a View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 lib/opal/nodes/def.rb
  2. +1 −1 opal/corelib/module.rb
2 changes: 1 addition & 1 deletion lib/opal/nodes/def.rb
Original file line number Diff line number Diff line change
@@ -114,7 +114,7 @@ def compile
unshift "def#{jsid} = "
end

wrap '(', ', nil)' if expr?
wrap '(', ", nil) && '#{mid}'" if expr?
end

# Returns code used in debug mode to check arity of method call
2 changes: 1 addition & 1 deletion opal/corelib/module.rb
Original file line number Diff line number Diff line change
@@ -271,7 +271,7 @@ def define_method(name, method = undefined, &block)
self._proto[jsid] = block;
$opal.donate(self, [jsid]);
return null;
return name;
}
end