[Truffle] Adding annotation to return an enumerator if no block is given to a method. #2720
Conversation
| final RubyProc block = RubyArguments.getBlock(frame.getArguments()); | ||
|
|
||
| if (block == null) { | ||
|
|
There was a problem hiding this comment.
Sorry to be a pain, but we don't want a blank line here...
bjfish
force-pushed
the
truffle_return_enumerator_annotation
branch
from
76bf07a to
eed837f
Compare
|
@chrisseaton I updated but wasn't sure if i got the adding and removing lines correct |
…tion [Truffle] Adding annotation to return an enumerator if no block is given to a method.
| public Object execute(VirtualFrame frame) { | ||
| final RubyProc block = RubyArguments.getBlock(frame.getArguments()); | ||
|
|
||
| if (block == null) { |
There was a problem hiding this comment.
I think we want a ConditionProfile here. We've essentially collapsed two specializations into one to consolidate a common pattern. But a given call site is apt to only use one form or the other.
|
@chrisseaton it would be nice if the style things could be checked with something like checkstyle Also, I have had trouble using raiseIfFrozen or the IsFrozenNode in a method after the method is to_enum'ed. Any ideas? I might try to debug this later on. |
|
|
||
| } else { | ||
| try { | ||
| return method.executeRubyBasicObject(frame); |
There was a problem hiding this comment.
This should probably be execute instead of executeRubyBasicObject. I'm not sure how often it happens (maybe never), but this wrapper won't work if the specialization returns a primitive.
There was a problem hiding this comment.
Yes, sorry these notes are both correct and important but I already merged - can submit another PR?
There was a problem hiding this comment.
I'll submit a new PR
No description provided.