Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of custom network properties. Addressing bug #3487. #8

Merged
merged 2 commits into from Feb 20, 2013

Conversation

egonw
Copy link
Member

@egonw egonw commented Feb 17, 2013

It allows for setting two principle network properties:

  1. the HTTP request time out
  2. the polling of OpenTox Task services

…on as soon as I add another prefs page, which does not even use that class... yes, really weird; really Eclipse
- the HTTP time out (with a new default of 50 secs)
- the shortest time when polling a Task (still at 2 secs)
- the longest time when polling a Task (still at 20 secs)
@goglepox
Copy link
Contributor

We are trying to move away from AbstractUIPlugin in the future and Activator.getPreferenceStore() comes from there.
I believe InstanceScope.INSTANCE.getNode( OpenToxConstants.PLUGIN_ID ) is better to use to get the properties, but the documentation on what to use is no help and PreferenceStore is used in the wizards.

If you got the time, otherwise we can fix it later.

@egonw
Copy link
Member Author

egonw commented Feb 20, 2013

It addresses an important issue for IdeaConsult, and would propose to apply it now, and file a bug report to fix it.

I saw Ola using InstanceScope.INSTANCE() but online docs indeed showed otherwise. That said, it seems to work together... if you have any docs, that would be great, but otherwise, I'll take the API HTML pages...

goglepox added a commit that referenced this pull request Feb 20, 2013
Allow setting of custom network properties. Addressing bug #3487.
@goglepox goglepox merged commit 35af67e into bioclipse:develop Feb 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants