Fix #3425: removeAllListeners should delete array

When removeAllListeners is called, the listeners array is deleted to maintain compatibility with v0.6. Reverts "events: don't delete the listeners array" This reverts commit 78dc13f. Conflicts: test/simple/test-event-emitter-remove-all-listeners.js
nodejs · Jun 15, 2012 · c9a1b5d · c9a1b5d
1 parent 13400e3
commit c9a1b5d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/lib/events.js b/lib/events.js
@@ -228,15 +228,8 @@ EventEmitter.prototype.removeAllListeners = function(type) {
     return this;
   }
 
-  var events = this._events && this._events[type];
-  if (!events) return this;
-
-  if (isArray(events)) {
-    events.splice(0);
-  } else {
-    this._events[type] = null;
-  }
-
+  // does not use listeners(), so no side effect of creating _events[type]
+  if (type && this._events && this._events[type]) this._events[type] = null;
   return this;
 };
 

diff --git a/test/simple/test-event-emitter-remove-all-listeners.js b/test/simple/test-event-emitter-remove-all-listeners.js
@@ -39,10 +39,15 @@ e1.removeAllListeners('baz');
 assert.deepEqual(e1.listeners('foo'), [listener]);
 assert.deepEqual(e1.listeners('bar'), []);
 assert.deepEqual(e1.listeners('baz'), []);
-// identity check, the array should not change
-assert.equal(e1.listeners('foo'), fooListeners);
-assert.equal(e1.listeners('bar'), barListeners);
-assert.equal(e1.listeners('baz'), bazListeners);
+// after calling removeAllListeners,
+// the old listeners array should stay unchanged
+assert.deepEqual(fooListeners, [listener]);
+assert.deepEqual(barListeners, [listener]);
+assert.deepEqual(bazListeners, [listener, listener]);
+// after calling removeAllListeners,
+// new listeners arrays are different from the old
+assert.notEqual(e1.listeners('bar'), barListeners);
+assert.notEqual(e1.listeners('baz'), bazListeners);
 
 var e2 = new events.EventEmitter();
 e2.on('foo', listener);